stacer: init at 1.1.0 #77808
stacer: init at 1.1.0 #77808
Conversation
|
LGTM, ran it-- it does look nice! Some of the features don't make sense for NixOS, so didn't try them to find out how that went but I don't think there's anything to be done about that. Haven't looked through the expression yet, will do it in the morning if not merged by then already ;). |
|
@GrahamcOfBorg build stacer |
| maintainers = with maintainers; [ jonringer ]; | ||
| }; | ||
| } | ||
|
|
|
|
||
| buildInputs = [ qtcharts ]; | ||
|
|
||
| enableParallelBuilding = true; |
There was a problem hiding this comment.
this is done by default with cmake
| enableParallelBuilding = true; |
|
The program is not completely hermetic because it tries to launch executables out of band with https://github.com/oguzhaninan/Stacer/search?p=1&q=CommandUtil%3A%3Aexec&unscoped_q=CommandUtil%3A%3Aexec I'm not sure if it's ok for the administration tool to have hardcoded paths to executables where appropriate, because some could be optional features or ones, as @dtzWill, don't make sense in NixOS. Example of what I recommend #65252 (comment). It's also cool to inject into |
I'm fine with wrapping, it doesn't look like they use any paths, just command names |
|
I'm having problems with it starting/using on my machine like oguzhaninan/Stacer#349. Strace reveals weird stuff not related to any nixpkgs shenanigans so I'm going to assume it's an undiscovered bug/s upstream. |
|
I'm not sure the nature of the issues, closing as I've lost interest in this |
Motivation for this change
wanted a nice looking monitoring tool
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)