Escape identifiers serializing selectors. #21189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Jan 15, 2020
There were a couple of instance where we serialized the AtomicString as an identifier without taking necessary escaping into account. This is fixing serialization for :state(), :lang(), and unrecognized ::-webkit-* pseudo elements. Bug: 1042181 Change-Id: Ic0ca090bb57798f2905e360a0c5728a303dab3c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2002609 Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#732126}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2002609
branch
from
38c0478
to
026bb43
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were a couple of instance where we serialized the AtomicString as
an identifier without taking necessary escaping into account. This is
fixing serialization for :state(), :lang(), and unrecognized
::-webkit-* pseudo elements.
Bug: 1042181
Change-Id: Ic0ca090bb57798f2905e360a0c5728a303dab3c4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2002609
Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org>
Commit-Queue: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#732126}