synergy: 1.8.8 -> 1.11.0 #77761
synergy: 1.8.8 -> 1.11.0 #77761
Conversation
Enzime
force-pushed
the
update-synergy
branch
from
3c41068
to
c761a3b
Compare
Enzime
force-pushed
the
update-synergy
branch
from
c761a3b
to
9706335
Compare
| ''; | ||
|
|
||
| doCheck = true; | ||
| checkPhase = "../bin/unittests"; |
There was a problem hiding this comment.
Not running the tests any more?
There was a problem hiding this comment.
They used to build automatically, but they removed it from the CMake, I've opened a corresponding issue here:
|
@GrahamcOfBorg build synergy |
|
The patch for Darwin no longer applies. Could you check if it still looks necessary, and either update it or delete it? If we can’t figure out how to actually build this on Darwin that’s okay, but we should at least get beyond patchPhase. |
|
@alyssais Taking a look at it now, I believe the |
|
@alyssais Taking a look at it now, I believe the `CMakeLists.txt` file
has changed since I made that patch. I don't have access to a macOS
machine to test building synergy. What are your thoughts on leaving
the patch there for someone in the future who is interested in fixing
this? It may be useful to them even though it doesn't apply, as I
suspect that removing the patch, Synergy will still not build on
Darwin.
We should either fix the patch or remove it. Otherwise, the thing that
first stops it from building will be a broken patch we left there, and
even if this Synergy or some future thing did build without the patch
our package would still be broken.
Have you checked it isn't an easily fixed conflict? We can try to build
on OfBorg either with an updated patch, or without a patch.
|
Remove patches that are no longer necessary
Enzime
force-pushed
the
update-synergy
branch
from
9706335
to
9f9754c
Compare
|
@alyssais Removed the Darwin patch, can you get @GrahamcOfBorg to build it on Darwin? |
|
@GrahamcOfBorg build synergy
|
|
Darwin failure. |
Motivation for this change
Remove patches that are no longer necessary. Untested on macOS.
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)