Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

squashfs-tools-ng: 0.7 -> 0.8 #77922

Merged
merged 1 commit into from Jan 29, 2020
Merged

squashfs-tools-ng: 0.7 -> 0.8 #77922

merged 1 commit into from Jan 29, 2020

Conversation

alyssais
Copy link
Member

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

tomberek
tomberek approved these changes Jan 17, 2020
View reviewed changes
Copy link
Contributor

@tomberek tomberek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Builds, runs, and functions (only tested on small files) on NixOS.

  • Removes a patch for BSD: not evaluated
  • Removes autoreconfhook

@alyssais
Copy link
Member Author

Going to try to fix build on Darwin.

@alyssais alyssais force-pushed the squashfs-tools-ng branch 7 times, most recently from 701adaf to 739d8fa Compare January 20, 2020 15:59
@alyssais
squashfs-tools-ng: 0.7 -> 0.8
7559280 
Gave up trying to build on Darwin.
@alyssais alyssais merged commit b7c59cc into NixOS:master Jan 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomberek tomberek tomberek approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@alyssais @tomberek