Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/dokuwiki: init module #77830

Merged
merged 1 commit into from Jan 25, 2020
Merged

nixos/dokuwiki: init module #77830

merged 1 commit into from Jan 25, 2020

Conversation

1000101
Copy link
Member

@1000101 1000101 commented Jan 16, 2020

Motivation for this change

Package DokuWiki - simple OpenSource wiki which doesn't require a database.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@mmahut
Copy link
Member

mmahut commented Jan 16, 2020

@GrahamcOfBorg test dokuwiki

aanderse
aanderse reviewed Jan 16, 2020
View reviewed changes
Copy link
Member

@aanderse aanderse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for writing this module. Writing this was on my todo list but I hadn't got around to it yet.

I was going to write this to use services.httpd instead of nginx, though. Maybe this is a good opportunity to have a module support both 🤔

nixos/modules/services/web-apps/dokuwiki.nix Outdated Show resolved Hide resolved
@mmahut
Copy link
Member

mmahut commented Jan 17, 2020

@GrahamcOfBorg test dokuwiki

@mmahut
Copy link
Member

mmahut commented Jan 17, 2020

Looks good to me, @aanderse do you want to add the httpd support now or with another next pull request?

aanderse
aanderse reviewed Jan 18, 2020
View reviewed changes
Copy link
Member

@aanderse aanderse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mmahut I'd love to write the httpd backend now but I'm not sure I'll get around to it on a timeline tat is fair to this PR so we'll forget it for now.

nixos/modules/services/web-apps/dokuwiki.nix Show resolved Hide resolved
@1000101
Copy link
Member Author

1000101 commented Jan 18, 2020

@mmahut I'd love to write the httpd backend now but I'm not sure I'll get around to it on a timeline tat is fair to this PR so we'll forget it for now.

I can take care of httpd integration but I would like to do that in a separate PR, if possible.

@aanderse
Copy link
Member

@1000101 don't feel obliged to do the httpd integration if you're not interested in it. If you are... cool, go ahead!

For a first module you have done an exceptional job on this. Good work! 🎉

@mmahut
Copy link
Member

mmahut commented Jan 19, 2020

@GrahamcOfBorg test dokuwiki

1 similar comment
@1000101
Copy link
Member Author

1000101 commented Jan 19, 2020

@GrahamcOfBorg test dokuwiki

@1000101
Copy link
Member Author

1000101 commented Jan 24, 2020

@GrahamcOfBorg test dokuwiki

@1000101
Copy link
Member Author

1000101 commented Jan 24, 2020

Should be good for final review / merge. I did test all the functions, refactored a few things and made some minor updates. It would be awesome to add httpd and plugins support as the next steps.

@mmahut mmahut merged commit 942568b into NixOS:master Jan 25, 2020
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/january-2020-in-nixos/5771/1

@1000101 1000101 deleted the dokuwiki branch February 5, 2020 21:45
@1000101 1000101 mentioned this pull request Feb 7, 2020
Open
17 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmahut mmahut mmahut left review comments

@bjornfor bjornfor bjornfor left review comments

@aanderse aanderse aanderse left review comments

@infinisil infinisil Awaiting requested review from infinisil

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@1000101 @mmahut @aanderse @nixos-discourse @bjornfor