Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

facetimehd: unstable-2016-10-09 -> unstable-2019-12-10 for kernels > 4.8 #77888

Closed
wants to merge 1 commit into from
Closed

facetimehd: unstable-2016-10-09 -> unstable-2019-12-10 for kernels > 4.8 #77888

wants to merge 1 commit into from

Conversation

kraem
Copy link
Member

@kraem kraem commented Jan 17, 2020

Motivation for this change

Facetimehd driver wouldn't load correctly when running the latest stable kernel as per patjak/facetimehd#143

If boot.kernelPackages = pkgs.linuxPackages_latest; is set I'd get this dmesg output:

[   62.729904] facetimehd: probe of 0000:02:00.0 failed with error -22

on a Macbook Pro 12,1

Things done

Bumped the https://github.com/patjak/bcwc_pcie driver to latest commit in said repo.
This enabled my facetime webcam to function again.

Other

I've tried to follow the rules for contributing. Please tell me if there's anything I need to change/do differently :)

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@kraem kraem requested review from grahamc and womfoo January 17, 2020 08:35
@alyssais
Copy link
Member

The comment says

Also update pkgs/os-specific/linux/firmware/facetimehd-firmware/

@kraem
Copy link
Member Author

kraem commented Jan 17, 2020 •
edited

I'm not sure what to update in it.

I can't see any difference from:

which was referenced in the comment in pkgs/os-specific/linux/firmware/facetimehd-firmware/

@grahamc
Copy link
Member

grahamc commented Jan 19, 2020

Thank you!

pull bot pushed a commit to i077/nixpkgs that referenced this pull request Jan 19, 2020
@grahamc
Merge pull request NixOS#77888 from kraem/master
14aca32 
facetimehd: unstable-2016-10-09 -> unstable-2019-12-10 for kernels > 4.8
@grahamc
Copy link
Member

grahamc commented Jan 19, 2020

This merged but GitHub is confused :)

@grahamc grahamc closed this Jan 19, 2020
@waldyrious waldyrious mentioned this pull request Jan 19, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grahamc grahamc Awaiting requested review from grahamc

@womfoo womfoo Awaiting requested review from womfoo

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kraem @alyssais @grahamc