Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python2Packages.pyezminc: remove #77840

Merged
merged 1 commit into from Jan 16, 2020
Merged

python2Packages.pyezminc: remove #77840

merged 1 commit into from Jan 16, 2020

Conversation

bcdarwin
Copy link
Member

Motivation for this change
  • package supports Python 2 only
  • develop-python3 branch exists but datatype tests fail
  • not updated since 2018
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@bcdarwin bcdarwin changed the title pythonPackages.pyezminc: remove python2Packages.pyezminc: remove Jan 16, 2020
@bcdarwin
pythonPackages.pyezminc: remove
f131111 
- package supports Python 2 only
- develop-python3 branch exists but datatype tests fail
- not updated since 2018
jonringer
jonringer approved these changes Jan 16, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reasoning seems on point
initiated by current maintainer

Nothing changed
https://github.com/NixOS/nixpkgs/pull/77840
$ nix-shell /home/jon/.cache/nix-review/pr-77840/shell.nix

@jonringer jonringer merged commit 54c409e into NixOS:master Jan 16, 2020
@bcdarwin bcdarwin deleted the rm-pyezminc branch January 16, 2020 22:31
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/january-2020-in-nixos/5771/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 8.has: clean-up 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bcdarwin @nixos-discourse @jonringer