Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: mockingbirdnest/Principia
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 0e174f86480e
Choose a base ref
...
head repository: mockingbirdnest/Principia
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 8ed6f6703701
Choose a head ref
  • 2 commits
  • 4 files changed
  • 1 contributor

Commits on Jan 16, 2020

  1. Fix test tolerances on Linux.

    pleroy committed Jan 16, 2020

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
    Copy the full SHA
    12b5e76 View commit details
  2. Merge pull request #2450 from pleroy/Tests

    Fix test tolerances on Linux
    pleroy authored Jan 16, 2020
    Copy the full SHA
    8ed6f67 View commit details
Showing with 8 additions and 6 deletions.
  1. +1 −1 geometry/rotation_test.cpp
  2. +1 −1 ksp_plugin_test/planetarium_test.cpp
  3. +2 −2 physics/euler_solver_test.cpp
  4. +4 −2 physics/inertia_tensor_test.cpp
2 changes: 1 addition & 1 deletion geometry/rotation_test.cpp
Original file line number Diff line number Diff line change
@@ -144,7 +144,7 @@ TEST_F(RotationTest, AppliedToSymmetricBilinearForm) {
EXPECT_THAT(rotation_a_(form_)(rotation_a_(vector_), rotation_a_(vector_)),
AlmostEquals(115.0 * Pow<3>(Metre), 0, 1));
EXPECT_THAT(rotation_b_(form_)(rotation_b_(vector_), rotation_b_(vector_)),
AlmostEquals(115.0 * Pow<3>(Metre), 5));
AlmostEquals(115.0 * Pow<3>(Metre), 1, 5));
EXPECT_THAT(rotation_c_(form_)(rotation_c_(vector_), rotation_c_(vector_)),
AlmostEquals(115.0 * Pow<3>(Metre), 0));
}
2 changes: 1 addition & 1 deletion ksp_plugin_test/planetarium_test.cpp
Original file line number Diff line number Diff line change
@@ -175,7 +175,7 @@ TEST_F(PlanetariumTest, PlotMethod0) {
EXPECT_THAT(rp2_lines[0].front().x() - rp2_lines[1].back().x(),
VanishesBefore(1 * Metre, 6));
EXPECT_THAT(rp2_lines[0].back().x() - rp2_lines[1].front().x(),
AlmostEquals(10.0 / Sqrt(399.0) * Metre, 48, 94));
AlmostEquals(10.0 / Sqrt(399.0) * Metre, 47, 94));

for (auto const& rp2_line : rp2_lines) {
for (auto const& rp2_point : rp2_line) {
4 changes: 2 additions & 2 deletions physics/euler_solver_test.cpp
Original file line number Diff line number Diff line change
@@ -884,8 +884,8 @@ TEST_F(EulerSolverTest, SeparatrixConstantMomentum) {
EXPECT_THAT(actual_angular_velocity,
AlmostEquals(expected_angular_velocity, 2));
EXPECT_THAT(actual_attitude(e1_), AlmostEquals(expected_attitude(e1_), 8));
EXPECT_THAT(actual_attitude(e2_), AlmostEquals(expected_attitude(e2_), 4));
EXPECT_THAT(actual_attitude(e3_), AlmostEquals(expected_attitude(e3_), 7));
EXPECT_THAT(actual_attitude(e2_), AlmostEquals(expected_attitude(e2_), 6, 7));
EXPECT_THAT(actual_attitude(e3_), AlmostEquals(expected_attitude(e3_), 6, 7));
}

// The data in this test are from Takahashi, Busch and Scheeres, Spin state and
6 changes: 4 additions & 2 deletions physics/inertia_tensor_test.cpp
Original file line number Diff line number Diff line change
@@ -311,7 +311,8 @@ TEST_F(InertiaTensorTest, Abdulghany) {
overall_inertia_overall_centre_of_mass,
1,
2,
AlmostEquals(-116640.0 * π / (4.0 + π) * SIUnit<MomentOfInertia>(), 0));
AlmostEquals(-116640.0 * π / (4.0 + π) * SIUnit<MomentOfInertia>(),
0, 1));
CheckInertiaTensorCoordinate(overall_inertia_overall_centre_of_mass,
2,
0,
@@ -320,7 +321,8 @@ TEST_F(InertiaTensorTest, Abdulghany) {
overall_inertia_overall_centre_of_mass,
2,
1,
AlmostEquals(-116640.0 * π / (4.0 + π) * SIUnit<MomentOfInertia>(), 0));
AlmostEquals(-116640.0 * π / (4.0 + π) * SIUnit<MomentOfInertia>(),
0, 1));
CheckInertiaTensorCoordinate(
overall_inertia_overall_centre_of_mass,
2,