Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

teeworlds: cmake instead of bam, oh joy! cleanup #77842

Merged
merged 2 commits into from Jan 26, 2020

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Jan 16, 2020

Motivation for this change

Looks like teeworlds offers cmake support
and since it is mentioned first in their README
I gave it a go and ... 馃榿 馃帀

This fixes long-standing issues I've had building teeworlds
with more exotic compilers
(including clang? but havne't tried it using nixpkgs-master lately...)
and makes it possible to greatly simplify the expression
with all the same files installed AFAICT.

I noticed bam now has no consumers in-tree,
but I'm content letting it sit there (and maybe bitrot if untested)
as long as it doesn't make things too awkward when we're hanging
and it sees teeworlds expression happier and healthier than ever before
and while that truly brings joy it hurts and is a constant reminder of
its mistakes and weaknesses and what could have been ....
well so I think we can maybe hold off on evicting it for now.
That seems kinda cruel. Likely teeworlds wouldn't be what it is today
if not for all bam has done for it.

Okay anyway >> <<.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

I've only tested the client?
And now that there's a build system we're familiar with... if anyone's
curious we might have some options to poke at.

(sorry bam ;3)

Copy link
Contributor

@tomberek tomberek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Builds and runs on NixOS.

Love the excitement in the PR.

@dtzWill dtzWill force-pushed the feature/teeworlds-cmake-hooray branch from fcd1ef9 to 5da8903 Compare January 17, 2020 15:29
@prusnak
Copy link
Member

prusnak commented Jan 18, 2020

Can we also change platforms and homepage while we are at it?

platforms = stdenv.lib.platforms.linux;
homepage = "https://teeworlds.com/";

@ajs124
Copy link
Member

ajs124 commented Jan 18, 2020

Has anything ever depended on bam? I seem to remember it as "the teeworlds build system".

@Mic92
Copy link
Member

Mic92 commented Jan 21, 2020

In that case bam could be even dropped.

@dtzWill
Copy link
Member Author

dtzWill commented Jan 26, 2020

Will leave dropping bam to a follow-up PR, 馃槆 .

@dtzWill dtzWill merged commit 24f531a into NixOS:master Jan 26, 2020
@dtzWill dtzWill deleted the feature/teeworlds-cmake-hooray branch January 26, 2020 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants