Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dotnetCorePackages updates and add missing netcore versions #77961

Merged
merged 15 commits into from Jan 19, 2020
Merged

dotnetCorePackages updates and add missing netcore versions #77961

merged 15 commits into from Jan 19, 2020

Conversation

nyanloutre
Copy link
Member

@nyanloutre nyanloutre commented Jan 18, 2020 •
edited

Motivation for this change
  • dotnet 2.2 is deprecated
  • update all other component
  • add runtime for all dotnet versions
  • use the new runtime package with Jellyfin

Packages that could be affected by the change:

  • eventstore (tested build)
  • wasabiwallet (tested build and run)
  • msbuild (tested build)
  • python3Packages.dotnetcore2 (tested build)
Things done

Ran the jellyfin test

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@nyanloutre nyanloutre changed the title dotnetCorePackages updates and Jellyfin switch to dotnet runtime dotnetCorePackages updates add missing netcore versions Jan 18, 2020
@nyanloutre nyanloutre changed the title dotnetCorePackages updates add missing netcore versions dotnetCorePackages updates and add missing netcore versions Jan 18, 2020
@ofborg ofborg bot requested a review from mmahut January 18, 2020 02:43
@nyanloutre nyanloutre mentioned this pull request Jan 18, 2020
Merged
10 tasks
jonringer
jonringer approved these changes Jan 19, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

[1 built, 0.0 MiB DL]
https://github.com/NixOS/nixpkgs/pull/77961
16 package built:
dotnet-aspnetcore dotnet-netcore dotnet-sdk dotnet-sdk_3 dotnetCorePackages.aspnetcore_3_0 dotnetCorePackages.aspnetcore_3_1 dotnetCorePackages.netcore_3_0 dotnetCorePackages.netcore_3_1 dotnetCorePackages.sdk_3_0 eventstore fsharp41 jellyfin msbuild python37Packages.dotnetcore2 python38Packages.dotnetcore2 wasabiwallet

@jonringer
Copy link
Contributor

@GrahamcOfBorg build dotnet-aspnetcore dotnet-netcore dotnet-sdk dotnet-sdk_3 dotnetCorePackages.aspnetcore_3_0 dotnetCorePackages.aspnetcore_3_1 dotnetCorePackages.netcore_3_0 dotnetCorePackages.netcore_3_1 dotnetCorePackages.sdk_3_0 eventstore fsharp41 jellyfin msbuild python37Packages.dotnetcore2 python38Packages.dotnetcore2 wasabiwallet

@jonringer
Copy link
Contributor

passed locally for x86-64, merging

@jonringer jonringer merged commit 21f74cc into NixOS:master Jan 19, 2020
@nyanloutre nyanloutre deleted the dotnet_updates branch January 19, 2020 23:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@baracoder baracoder baracoder left review comments

@jonringer jonringer jonringer approved these changes

@mmahut mmahut Awaiting requested review from mmahut mmahut is a code owner

Assignees
No one assigned
Labels
8.has: clean-up 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@nyanloutre @jonringer @baracoder