onedrive: 2.3.12 -> 2.3.13 #77854
onedrive: 2.3.12 -> 2.3.13 #77854
Conversation
alyssais
changed the title
|
I’ve changed the pull request title to make it clearer that this is not just a minor package bump. Can you please split your commit into two, one two bump the package, and another to add the module? |
|
Is your module actually usable? Have you tested it? I ask because it hasn’t been added to module-list.nix. |
|
I have created another module here #77734 which allows running OneDrive services for multiple accounts. The version bump is fine. I'm not |
ianmjones
force-pushed
the
onedrive-2.3.13
branch
from
fae74be
to
c02c81d
Compare
|
@alyssais Thanks for taking a look at this PR and giving me some hints, much appreciated. I've split the version bump and module addition into two commits. I've tested this locally, just forgot to add that change to module-list.nix to git, it's in that second commit now, sorry about that! @SRGOM Oops, didn't see that PR, looks interesting, I'll leave some comments/questions on it in a bit. |
|
Hey all, I'm going to be really busy at the next few weeks, and I have little to no interest at all in this package or service, so I don't have time to review this. Sorry. |
|
@doronbehar No worries, shall I take you out of the maintainers list as part of the version bump? @alyssais & @SRGOM I'm thinking I should remove the module stuff from this PR and we should just go with #77734, sound good? If so, would be great if you could maybe add the |
|
@ianmjones I have added |
|
@ianmjones yes, please remove me from the maintainers list. |
ianmjones
force-pushed
the
onedrive-2.3.13
branch
from
c02c81d
to
2533666
Compare
ianmjones
changed the title
|
@alyssais Thanks, I've removed the module, so it's just a version bump with @doronbehar removed from the maintainers as requested. |
|
Thanks @alyssais! |
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/steps-to-find-a-commit-with-cached-version-of-package/5674/1 |
Motivation for this change
Upgrade OneDrive to latest version.
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)@doronbehar Hope this is ok to submit as a PR and add myself as a maintainer.
I've been using OneDrive with an almost identical Nix file for a couple of months via an overlay, and just as I went to add it to nixpkgs found your version!
This is an update to the latest release, adds in the ability to possibly get notifications by compiling with that option, and runs the
default.nixfile throughnixfmtto help standardise the format.