Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lwan: fix w/musl re:secure_getenv (fix build) #77847

Closed
wants to merge 1 commit into from
Closed

lwan: fix w/musl re:secure_getenv (fix build) #77847

wants to merge 1 commit into from
+4 −0

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Jan 16, 2020

Motivation for this change

Fix lwan build braek w/musl due to secure_getenv
being detected as unavailable and conflicts from
the lwan-provided version.

Things done

(I've tested this fixes lwan and produces a maybe-working lwan
(well, it runs?) but haven't checked on this tree yet and
don't have it built for musl yet...)

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Jan 16, 2020
@dtzWill
Copy link
Member Author

dtzWill commented Jan 16, 2020

@GrahamcOfBorg build pkgsMusl.lwan

@lpereira
Copy link

Thanks! Thinking about setting up a buildbot instance running Musl to catch these kinds of issues. I've pushed a patch upstream that fixes this; I'm planning to release 0.3 soon, which will include the fix.

@dtzWill
Copy link
Member Author

dtzWill commented Feb 13, 2020

Thanks, works with 0.3 \o/.

@dtzWill dtzWill closed this Feb 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dtzWill @lpereira