lwan: fix w/musl re:secure_getenv (fix build) #77847
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@GrahamcOfBorg build pkgsMusl.lwan |
|
Thanks! Thinking about setting up a buildbot instance running Musl to catch these kinds of issues. I've pushed a patch upstream that fixes this; I'm planning to release 0.3 soon, which will include the fix. |
|
Thanks, works with 0.3 \o/. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Fix lwan build braek w/musl due to secure_getenv
being detected as unavailable and conflicts from
the lwan-provided version.
Things done
(I've tested this fixes lwan and produces a maybe-working lwan
(well, it runs?) but haven't checked on this tree yet and
don't have it built for musl yet...)
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)