cbatticon: wrapGAppsHook to fix icon issue in service #77856
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks to folks on home-manager issue 988 for sorting this out! nix-community/home-manager#988 (comment) (thread for the issue this fixes, where this was suggested) Works for me, FWIW :)
|
Whoops, I completely missed your PR and now mine #77947 has been accepted instead... Thanks for trying to sort this out for me and sorry for the duplicated work! :) |
|
Hahaha all good! And wasn't just for you, I had rejected use of home-manager's cbatticon service after encountering exactly the issue you did .. thanks for the fix! ^_^ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Motivation is "to fix icon issue in service" :).
Thanks to folks on home-manager issue 988 for sorting this out!
nix-community/home-manager#988 (comment)
(thread for the issue this fixes, where this was suggested)
Works for me after this fix, too :).
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)Anyone worried about this possibly making this lightweight app too
heavy?
Can make it optional but wasn't sure that was worth the complexity
(for example, if no one would ever choose to not wrap it :)).