Skip to content

vscode-extensions.ms-python.python: 2019.10.44104 update language server to 0.4.127 #77962

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 24, 2020
Merged

vscode-extensions.ms-python.python: 2019.10.44104 update language server to 0.4.127 #77962

merged 1 commit into from
Jan 24, 2020
+3 −3

Conversation

tbenst
Copy link
Contributor

@tbenst tbenst commented Jan 18, 2020

Motivation for this change

close #77341 take 2

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@tbenst tbenst requested a review from jonringer as a code owner January 18, 2020 02:49
@tbenst tbenst changed the title Vscode python vscode-extensions.ms-python.python: 2019.10.44104 update language server to 0.4.127 Jan 18, 2020
@ofborg ofborg bot added the 2.status: merge conflict This PR has merge conflicts with the target branch label Jan 18, 2020
@jonringer
Copy link
Contributor

please squash the commits and rebase

@tbenst
Copy link
Contributor Author

tbenst commented Jan 23, 2020

@jonringer sorry for my delay, rebased

@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux and removed 2.status: merge conflict This PR has merge conflicts with the target branch labels Jan 23, 2020
jonringer
jonringer approved these changes Jan 24, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

$ nix-build ./nixpkgs/ -A vscode-extensions.ms-python.python

builds

@jonringer jonringer merged commit e1e7da4 into NixOS:master Jan 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ms-python.python: fails to build as file not hosted
2 participants
@tbenst @jonringer