Re-organize the buildkite agent module #77831
Closed
+50
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ofborg
bot
added
6.topic: nixos
There are four changes: * Made `openssh.privateKeyPath` and `openssh.publicKeyPath` optional. * Made the `meta-deta` confinguration option accept a string dictionary instead of a plain string. * In the version 3.x of buildkite agent `meta-data` is called `tags`. To keep support for both 2.x and 3.x versions of the agent, I just added the configuration option called `tags` which mirrors `meta-data`. * In the previous commit it should have been `cfg.package` instead of `cfg.buildkite-agent`. This commit fixes that.
mrkkrp
force-pushed
the
improve-buildkite-service
branch
from
dafa0f2 to
b70ea63
Compare
ofborg
bot
added
10.rebuild-darwin: 0
|
I already had some work going on in #68378, which cleans up even more stuff (and drops buildkite v2 - as the latest release there was in Jan 2018). I'm currently rebasing that on top of master. |
10 tasks
|
Are you fine to close this in favor of #77950? |
|
Yes, let's close. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Improve usability of the buildkite agent module, especially with the version 3.x of the agent.
There are four changes:
openssh.privateKeyPathandopenssh.publicKeyPathoptional.meta-detaconfinguration option accept a string dictionaryinstead of a plain string.
meta-datais calledtags. Tokeep support for both 2.x and 3.x versions of the agent, I just added the
configuration option called
tagswhich mirrorsmeta-data.cfg.packageinstead ofcfg.buildkite-agent. This commit fixes that.Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)