gnunet-gtk: init at 0.12.0 #77828
Merged
gnunet-gtk: init at 0.12.0 #77828
+30
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ofborg
bot
added
8.has: package (new)
mehlon
reviewed
Jan 29, 2020
|
|
||
| meta = with stdenv.lib; { | ||
| description = "GNUnet GTK User Interface"; | ||
| homepage = https://github.com/ajf8/transmission-remote-gtk; |
There was a problem hiding this comment.
homepage = https://git.gnunet.org/gnunet-gtk.git
| meta = with stdenv.lib; { | ||
| description = "GNUnet GTK User Interface"; | ||
| homepage = https://github.com/ajf8/transmission-remote-gtk; | ||
| license = licenses.gpl3; |
| homepage = https://github.com/ajf8/transmission-remote-gtk; | ||
| license = licenses.gpl3; | ||
| maintainers = with maintainers;[ pstn ]; | ||
| platforms = platforms.linux; |
There was a problem hiding this comment.
should be platforms.gnu ++ platforms.linux (same as gnunet)
|
Ah, I realize I should have used the "suggest changes" option for GitHub instead. Oh well. |
pstn
force-pushed
the
gnunet-gtk
branch
3 times, most recently
from
aefc017 to
27ebb52
Compare
|
Rebased my branch on master, resolved the issues and rebuilt the package. |
|
repushed just for signature |
|
ping @jonringer for review before feature freeze. |
jonringer
reviewed
Aug 4, 2020
|
|
||
| meta = with stdenv.lib; { | ||
| description = "GNUnet GTK User Interface"; | ||
| homepage = https://git.gnunet.org/gnunet-gtk.git; |
There was a problem hiding this comment.
rfc 45
Suggested change
| homepage = https://git.gnunet.org/gnunet-gtk.git; | |
| homepage = "https://git.gnunet.org/gnunet-gtk.git"; |
pstn
force-pushed
the
gnunet-gtk
branch
2 times, most recently
from
55de181 to
d93f339
Compare
jonringer
reviewed
Aug 4, 2020
There was a problem hiding this comment.
installation seems to be missing some localization:
$ strace ./results//gnunet-gtk/bin/gnunet-fs-gtk
....
openat(AT_FDCWD, "/nix/store/jjcw4g52zjzw4nvqmrl2nfpqzvdlr58i-gnunet-gtk-0.12.0/share/gnunet//GNUnet GTK/locale//en_US.UTF-8/LC_MESSAGES/gnunet-gtk.mo", O_RDONLY) = -1 ENOENT (No such file or directory)
openat(AT_FDCWD, "/nix/store/jjcw4g52zjzw4nvqmrl2nfpqzvdlr58i-gnunet-gtk-0.12.0/share/gnunet//GNUnet GTK/locale//en_US.utf8/LC_MESSAGES/gnunet-gtk.mo", O_RDONLY) = -1 ENOENT (No such file or directory)
openat(AT_FDCWD, "/nix/store/jjcw4g52zjzw4nvqmrl2nfpqzvdlr58i-gnunet-gtk-0.12.0/share/gnunet//GNUnet GTK/locale//en_US/LC_MESSAGES/gnunet-gtk.mo", O_RDONLY) = -1 ENOENT (No such file or directory)
openat(AT_FDCWD, "/nix/store/jjcw4g52zjzw4nvqmrl2nfpqzvdlr58i-gnunet-gtk-0.12.0/share/gnunet//GNUnet GTK/locale//en.UTF-8/LC_MESSAGES/gnunet-gtk.mo", O_RDONLY) = -1 ENOENT (No such file or directory)
openat(AT_FDCWD, "/nix/store/jjcw4g52zjzw4nvqmrl2nfpqzvdlr58i-gnunet-gtk-0.12.0/share/gnunet//GNUnet GTK/locale//en.utf8/LC_MESSAGES/gnunet-gtk.mo", O_RDONLY) = -1 ENOENT (No such file or directory)
openat(AT_FDCWD, "/nix/store/jjcw4g52zjzw4nvqmrl2nfpqzvdlr58i-gnunet-gtk-0.12.0/share/gnunet//GNUnet GTK/locale//en/LC_MESSAGES/gnunet-gtk.mo", O_RDONLY) = -1 ENOENT (No such file or directory)
--- SIGSEGV {si_signo=SIGSEGV, si_code=SEGV_MAPERR, si_addr=0x48} ---
+++ killed by SIGSEGV (core dumped) +++
Segmentation fault (core dumped)
jonringer
approved these changes
Aug 4, 2020
|
I could reproduce the weird locale search path but not the segmentation fault. Curious. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I worked on top of #77785 for a newer gnunet version, so please only merge after that PR.
Motivation for this change
Fixes #76754 and I want it.
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)