Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bibata-{,extra-}cursors: fix, faster, smaller; bump extra variant from git -> 0.3 #77852

Merged
merged 2 commits into from Jan 26, 2020
Merged

bibata-{,extra-}cursors: fix, faster, smaller; bump extra variant from git -> 0.3 #77852

merged 2 commits into from Jan 26, 2020

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Jan 16, 2020

Motivation for this change

This fixes issue where each theme installed the entire build directory, not
just the final generated 'out/X11' files.

(which was wasteful but also meant they didn't work as the right files were
two directories deeper)

Avoiding the w32 saves some time and sapce, and more is "saved" by not
shipping non-cursor build intermediates.

Sorry for the bad update, folks!

While visiting these, checked on bibata-extra-cursors and turns out it
has a new release and needed all of the same treatment :).

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@dtzWill
bibata-cursors: fix installation, don't generate unused w32 artifacts
509e0a0 
This fixes issue where each theme installed the entire
build directory, not just the final generated 'out/X11' files.

(which was wasteful but also meant they didn't work
as the right files were two directories deeper)

Avoiding the w32 saves some time and sapce,
and more is "saved" by not shipping non-cursor build intermediates.

Sorry for the bad update, folks!
@dtzWill
bibata-extra-cursors: unstable-2018-10-28 -> 0.3, sync w/bibata-cursors
2d82668
@ofborg ofborg bot requested a review from rawkode January 16, 2020 23:51
justinlovinger
justinlovinger reviewed Jan 17, 2020
View reviewed changes
Copy link
Contributor

@justinlovinger justinlovinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see any issues with the changes. I'm not sure we should just throw away the Windows cursors, but I'm not aware of a better solution.

@dtzWill
Copy link
Member Author

dtzWill commented Jan 26, 2020

The windows cursors weren't installed previously either, this just skips spending time generating them (since they aren't installed anyway).

@dtzWill dtzWill merged commit 05d2015 into NixOS:master Jan 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justinlovinger justinlovinger justinlovinger left review comments

@rawkode rawkode rawkode approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dtzWill @rawkode @justinlovinger