Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fish: fix systemctl completion #77951

Merged
merged 1 commit into from Jan 17, 2020
Merged

fish: fix systemctl completion #77951

merged 1 commit into from Jan 17, 2020

Conversation

gebner
Copy link
Member

@gebner gebner commented Jan 17, 2020

Motivation for this change

Type systemctl rest<TAB> in fish and you get the following error message:

 archachatina  ~  systemctl restart diInteger 243 in '243 (243)' followed by non-digit           Fri 17 Jan 2020 05:43:35 PM CET
        Integer 243 in '243 (243)' followed by non-digit

(The error message is shown twice and messes up the prompt, which drives me crazy.)

Unfortunately it's not clear when the next fish release is going to be (see fish-shell/fish-shell#5934), so I'd like to patch this now.

cc maintainer @ocharles

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from ocharles January 17, 2020 17:04
@gebner gebner merged commit fde2877 into NixOS:master Jan 17, 2020
@aanderse
Copy link
Member

Thanks @gebner! Is a backport to 19.09 trivial enough?

@gebner
Copy link
Member Author

gebner commented Jan 17, 2020

@aanderse 09aa1b2

@gebner gebner mentioned this pull request Jan 18, 2020
Closed
@flokli flokli mentioned this pull request Jan 24, 2020
Closed
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ocharles ocharles Awaiting requested review from ocharles

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@gebner @aanderse