Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

unoconv: 0.6 -> 0.8.2 #77832

Merged
merged 1 commit into from Jan 16, 2020
Merged

unoconv: 0.6 -> 0.8.2 #77832

merged 1 commit into from Jan 16, 2020

Conversation

akirak
Copy link
Contributor

@akirak akirak commented Jan 16, 2020

Things done

Update unoconv, the document converter based on LibreOffice, from 0.6 to 0.8.2.

unoconv 0.6 was released in 2012 --- It's outdated. It lacked some command line options I was desperate for, so I will send this PR.

The source repository was an HTTP site. I have changed it to GitHub.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

alyssais
alyssais requested changes Jan 16, 2020
View reviewed changes
pkgs/tools/text/unoconv/default.nix Outdated Show resolved Hide resolved
pkgs/tools/text/unoconv/default.nix Outdated Show resolved Hide resolved
pkgs/tools/text/unoconv/default.nix Outdated Show resolved Hide resolved
@ofborg ofborg bot requested a review from bjornfor January 16, 2020 16:46
@akirak
Copy link
Contributor Author

akirak commented Jan 16, 2020

Thanks, I've fixed the issues.

@akirak
unoconv: 0.6 -> 0.8.2
f7a17cb 
Change the source from dag.wieers.com to github, which seems to
officially host the source code of the project now.

Update unoconv from 0.6 to 0.8.2, which includes several important
changes.

Delete the patch, since it has already become part of the project.
@akirak
Copy link
Contributor Author

akirak commented Jan 16, 2020

Fixed.

@ofborg ofborg bot requested a review from bjornfor January 16, 2020 17:46
@alyssais alyssais merged commit 1e70a7e into NixOS:master Jan 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alyssais alyssais alyssais requested changes

@bjornfor bjornfor bjornfor approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@akirak @bjornfor @alyssais