Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

corerad: 0.1.4 -> 0.1.8 #77848

Merged
merged 1 commit into from Jan 17, 2020
Merged

corerad: 0.1.4 -> 0.1.8 #77848

merged 1 commit into from Jan 17, 2020

Conversation

mdlayher
Copy link
Member

@mdlayher mdlayher commented Jan 16, 2020 •
edited

Motivation for this change

Latest alpha release of CoreRAD which better handles network link state changes.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Built locally and verified working binary:

[matt@routnerr-2:~/src/nixpkgs]$ nix-build -A corerad                                                                                                                    
these derivations will be built:
  /nix/store/yyp7mr1f6m1xax2ws6lmipz79rsc4r9v-corerad-0.1.8.drv
building '/nix/store/yyp7mr1f6m1xax2ws6lmipz79rsc4r9v-corerad-0.1.8.drv'...                                                                                                       
[...]
[matt@routnerr-2:~/src/nixpkgs]$ ./result/bin/corerad -init

[matt@routnerr-2:~/src/nixpkgs]$ ./result/bin/corerad
2020/01/16 15:45:03 CoreRAD v0.1.8 (ALPHA) starting with configuration file "corerad.toml"
2020/01/16 15:45:03 eth0: send advertisements is false, skipping initialization
2020/01/16 15:45:03 starting HTTP debug listener on "localhost:9430": prometheus: false, pprof: false

^C2020/01/16 15:45:14 received interrupt, shutting down

@ofborg ofborg bot requested a review from kalbasit January 16, 2020 21:02
danderson
danderson approved these changes Jan 16, 2020
View reviewed changes
Copy link
Contributor

@danderson danderson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kalbasit kalbasit merged commit 9c66687 into NixOS:master Jan 17, 2020
dtzWill pushed a commit to dtzWill/nixpkgs that referenced this pull request Jan 17, 2020
@mdlayher @dtzWill
corerad: 0.1.4 -> 0.1.8 (NixOS#77848)
51c18ed 
(cherry picked from commit 9c66687)
@mdlayher mdlayher deleted the mdl-corerad-0.1.8 branch January 4, 2021 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danderson danderson danderson approved these changes

@kalbasit kalbasit kalbasit approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mdlayher @danderson @kalbasit