Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

zopfli: 1.0.2 -> 1.0.3 #77956

Merged
merged 1 commit into from Jan 18, 2020
Merged

zopfli: 1.0.2 -> 1.0.3 #77956

merged 1 commit into from Jan 18, 2020

Conversation

ajs124
Copy link
Member

@ajs124 ajs124 commented Jan 17, 2020

Motivation for this change

New upstream release.

This ships with the cmake build system merged, so we can drop the patch and custom install phase.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from bobvanderlinden January 17, 2020 22:49
@edef1c
Copy link
Member

edef1c commented Jan 18, 2020

This seems to add the headers to $out as well, where they were previously missing entirely. Thanks!

@edef1c edef1c merged commit 201d9b8 into NixOS:master Jan 18, 2020
@ajs124 ajs124 deleted the upd/zopfli branch January 18, 2020 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bobvanderlinden bobvanderlinden Awaiting requested review from bobvanderlinden

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ajs124 @edef1c