Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v4l2loopback: 0.12.2 -> 0.12.3 #77882

Merged
merged 1 commit into from Jan 20, 2020
Merged

v4l2loopback: 0.12.2 -> 0.12.3 #77882

merged 1 commit into from Jan 20, 2020

Conversation

colemickens
Copy link
Member

Tested. I couldn't get it to work until I upgraded? Barely works anyway, but I think that v4l2's fault...

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from domenkozar January 17, 2020 08:32
@nh2
Copy link
Contributor

nh2 commented Jan 18, 2020

@GrahamcOfBorg build

nh2
nh2 approved these changes Jan 18, 2020
View reviewed changes
Copy link
Contributor

@nh2 nh2 left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changelog: umlaeute/v4l2loopback@c1ea508#diff-02f0b547c2779d25cff89672135f20e3

* Fixed compat with kernel 5.4

@nh2
Copy link
Contributor

nh2 commented Jan 18, 2020

@GrahamcOfBorg build linuxPackages.v4l2loopback linuxPackages_5_4.v4l2loopback

@nh2
Copy link
Contributor

nh2 commented Jan 20, 2020

This seems to work, merging.

@nh2 nh2 merged commit b17d21d into NixOS:master Jan 20, 2020
@colemickens colemickens deleted the nixpkgs-v4l2-fix branch January 30, 2020 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nh2 nh2 nh2 approved these changes

@domenkozar domenkozar Awaiting requested review from domenkozar

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@colemickens @nh2