WIP: dracut: init at 049 #77868

CMCDragonkai · 2020-01-17T05:16:32Z

Motivation for this change

This derivation still has some problems. In particular realpath is not found in the dracut command. And also the dracutbasedir has shell scripts there that have not been properly wrapped as well. And also I need to wrap the bin scripts with a PATH to itself, but not sure if that means I need to add $out to the lib.makeBinPath.

Things done

CMCDragonkai · 2020-01-17T05:17:06Z

Also is running wrapProgram like that recommended?

CMCDragonkai · 2020-01-17T07:52:52Z

If somebody knows more how to package this better, please recommend.

ajs124

No idea if wrapProgram is intended to be used like that.

ajs124 · 2020-01-18T21:25:30Z

pkgs/os-specific/linux/dracut/default.nix

+}:
+
+stdenv.mkDerivation rec {
+  name = "dracut";


why name and not pname?

pname is just name right and then combined with version right?

Usually pname is preferred and if that's used without name, mkDerivation and all it's friends create automatically this attribute: name = "${pname}-${version};" - this name is different then yours.

ajs124 · 2020-01-18T21:25:54Z

pkgs/os-specific/linux/dracut/default.nix

+stdenv.mkDerivation rec {
+  name = "dracut";
+  version = "049";
+  src = fetchurl {


Is there a reason why you didn't use fetchFromGitHub?

Does that fetch the releases?

@ajs124 is right @CMCDragonkai - We prefer fetchFromGitHub since it's easier to parse our package set that way and it's easier to override the revision (rev) with the \\ operator. Plus, it might be useful in the future when automatic updaters scripts will see that instead of the too generic fetchurl.

CMCDragonkai · 2020-01-18T22:51:41Z

Does fetchFromGithub get releases? I forgot. Any alternative to setting the PATH for all the scripts?

…

On 19 January 2020 08:29:05 GMT+11:00, ajs124 ***@***.***> wrote: ajs124 requested changes on this pull request. No idea if `wrapProgram` is intended to be used like that. > +, utillinux +, gnused +, gnugrep +, squashfsTools +, cpio +, binutils +, gzip +, bzip2 +, lz4 +, lzop +, zstd +, xz +}: + +stdenv.mkDerivation rec { + name = "dracut"; why name and not pname? > +, gnugrep +, squashfsTools +, cpio +, binutils +, gzip +, bzip2 +, lz4 +, lzop +, zstd +, xz +}: + +stdenv.mkDerivation rec { + name = "dracut"; + version = "049"; + src = fetchurl { Is there a reason why you didn't use fetchFromGitHub? -- You are receiving this because you authored the thread. Reply to this email directly or view it on GitHub: #77868 (review)

-- Sent from my Android device with K-9 Mail. Please excuse my brevity.

doronbehar · 2020-03-22T13:38:53Z

pkgs/os-specific/linux/dracut/default.nix

+}:
+
+stdenv.mkDerivation rec {
+  name = "dracut";


Usually pname is preferred and if that's used without name, mkDerivation and all it's friends create automatically this attribute: name = "${pname}-${version};" - this name is different then yours.

doronbehar · 2020-03-22T13:44:03Z

pkgs/os-specific/linux/dracut/default.nix

+stdenv.mkDerivation rec {
+  name = "dracut";
+  version = "049";
+  src = fetchurl {


@ajs124 is right @CMCDragonkai - We prefer fetchFromGitHub since it's easier to parse our package set that way and it's easier to override the revision (rev) with the \\ operator. Plus, it might be useful in the future when automatic updaters scripts will see that instead of the too generic fetchurl.

doronbehar · 2020-03-22T13:53:34Z

pkgs/os-specific/linux/dracut/default.nix

+      --replace 'dracutbasedir=/usr/lib/dracut' "dracutbasedir=$out/lib/dracut"
+  '';
+  postFixup = ''
+    wrapProgram $out/bin/dracut --set PATH ${lib.makeBinPath [


No idea if wrapProgram is intended to be used like that.

@ajs124 I think it's supposed to be OK, see https://nixos.org/nixpkgs/manual/#ssec-stdenv-functions .

doronbehar · 2020-03-22T14:04:02Z

pkgs/os-specific/linux/dracut/default.nix

+    substituteInPlace lsinitrd.sh \
+      --replace 'dracutbasedir=/usr/lib/dracut' "dracutbasedir=$out/lib/dracut"
+  '';
+  postFixup = ''


Any alternative to setting the PATH for all the scripts?

I think @CMCDragonkai you can do something like this (not tested):

Suggested change

postFixup = ''

# put here all the packages you need - wrap them all

wrapPATH = lib.makeBinPath [ ... ];

postFixup = ''

wrapProgram $out/bin/dracut --set PATH ${wrapPATH}

'';

BUT, TBH I'm a bit conflicted whether all of those packages are needed as they are expected to be available in almost every environment. Personally, I'd drop at least:

gzip

bzip2

xz

gnugrep

gnused

BTW I assume makeBinPath uses the order of the packages it gets in order to give precedence in $PATH. Hence, If upstream requires explicitly gnused instead whatever's in coreutils, you should put gnused before coreutils.

I think the derivation should be as pure as possible to ensure that if I package dracut in a docker container it should have everything.

pkgs/os-specific/linux/dracut/default.nix

stale · 2020-09-18T16:42:19Z

Hello, I'm a bot and I thank you in the name of the community for your contributions.

Nixpkgs is a busy repository, and unfortunately sometimes PRs get left behind for too long. Nevertheless, we'd like to help committers reach the PRs that are still important. This PR has had no activity for 180 days, and so I marked it as stale, but you can rest assured it will never be closed by a non-human.

If this is still important to you and you'd like to remove the stale label, we ask that you leave a comment. Your comment can be as simple as "still important to me". But there's a bit more you can do:

If you received an approval by an unprivileged maintainer and you are just waiting for a merge, you can @ mention someone with merge permissions and ask them to help. You might be able to find someone relevant by using Git blame on the relevant files, or via GitHub's web interface. You can see if someone's a member of the nixpkgs-committers team, by hovering with the mouse over their username on the web interface, or by searching them directly on the list.

If your PR wasn't reviewed at all, it might help to find someone who's perhaps a user of the package or module you are changing, or alternatively, ask once more for a review by the maintainer of the package/module this is about. If you don't know any, you can use Git blame on the relevant files, or GitHub's web interface to find someone who touched the relevant files in the past.

If your PR has had reviews and nevertheless got stale, make sure you've responded to all of the reviewer's requests / questions. Usually when PR authors show responsibility and dedication, reviewers (privileged or not) show dedication as well. If you've pushed a change, it's possible the reviewer wasn't notified about your push via email, so you can always officially request them for a review, or just @ mention them and say you've addressed their comments.

Lastly, you can always ask for help at our Discourse Forum, or more specifically, at this thread or at #nixos' IRC channel.

stale · 2021-06-04T14:02:46Z

I marked this as stale due to inactivity. → More info

Co-authored-by: Doron Behar <doron.behar@gmail.com>

stale · 2022-01-09T00:07:14Z

I marked this as stale due to inactivity. → More info

lilyinstarlight · 2023-01-10T17:36:58Z

I've continued this PR in #210075

dracut: init at 049

e4b3990

ofborg bot added 8.has: package (new) 11.by: package-maintainer 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 labels Jan 17, 2020

ajs124 requested changes Jan 18, 2020

View reviewed changes

doronbehar requested changes Mar 22, 2020

View reviewed changes

stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Sep 18, 2020

ryantm marked this pull request as draft October 23, 2020 03:02

stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Oct 23, 2020

stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jun 4, 2021

Update pkgs/os-specific/linux/dracut/default.nix

d617657

Co-authored-by: Doron Behar <doron.behar@gmail.com>

stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jun 7, 2021

stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jan 9, 2022

lilyinstarlight mentioned this pull request Jan 10, 2023

dracut: init at 059 #210075

Merged

13 tasks

stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jan 10, 2023

ehmry closed this in #210075 Jan 16, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

WIP: dracut: init at 049 #77868

WIP: dracut: init at 049 #77868

CMCDragonkai commented Jan 17, 2020

CMCDragonkai commented Jan 17, 2020

CMCDragonkai commented Jan 17, 2020

ajs124 left a comment

ajs124 Jan 18, 2020

CMCDragonkai Jan 20, 2020

doronbehar Mar 22, 2020

ajs124 Jan 18, 2020

CMCDragonkai Jan 20, 2020

doronbehar Mar 22, 2020

CMCDragonkai commented Jan 18, 2020 via email

doronbehar Mar 22, 2020

doronbehar Mar 22, 2020

doronbehar Mar 22, 2020

doronbehar Mar 22, 2020

CMCDragonkai Jun 7, 2021

stale bot commented Sep 18, 2020

stale bot commented Jun 4, 2021

stale bot commented Jan 9, 2022

lilyinstarlight commented Jan 10, 2023

-  postFixup = ''
+  # put here all the packages you need - wrap them all
+  wrapPATH = lib.makeBinPath [ ... ];
+  postFixup = ''
+    wrapProgram $out/bin/dracut --set PATH ${wrapPATH}
+  '';

WIP: dracut: init at 049 #77868

WIP: dracut: init at 049 #77868

Conversation

CMCDragonkai commented Jan 17, 2020

Motivation for this change

Things done

CMCDragonkai commented Jan 17, 2020

CMCDragonkai commented Jan 17, 2020

ajs124 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

CMCDragonkai commented Jan 18, 2020 via email

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

stale bot commented Sep 18, 2020

stale bot commented Jun 4, 2021

stale bot commented Jan 9, 2022

lilyinstarlight commented Jan 10, 2023