Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hfsprogs: 332.25 -> 540.1.linux3 #77867

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Jan 17, 2020

Motivation for this change

This is what most distributions ship for hfsprogs,
significantly newer than 332.25 (10.4.11[1], 2005) but only
about half as old (first appears in 10.7[2], 2011).

The newer tools drop support for mkfs.hfs (creating an HFS partition)
however they retain the ability to check both HFS and HFS+.

This seems like a small cost, and can be addressed by either reviving
the 332.25 variant or using hfsutils[3][4]. Coming soon, maybe? :D

It seems HFS drives and images are already unsupported and have been
for quite some time, so while it is unfortunate to drop support
the filesystem creators Apple apparently are very done with it:

"With the introduction of Mac OS X 10.6, Apple dropped support for
formatting or writing HFS disks and images, which remain supported as
read-only volumes. Starting with macOS 10.15, HFS disks can no longer
be read. "[5]

[1] https://opensource.apple.com/release/mac-os-x-10411x86.html
[2] https://opensource.apple.com/release/mac-os-x-107.html
[3] https://www.mars.org/home/rob/proj/hfs/
[4] https://packages.debian.org/source/sid/hfsutils (for patches)
[5] https://en.wikipedia.org/wiki/Hierarchical_File_System


Previously:

  • hfsprogs was dropped before and restored:

Also:

Added hfsutils in PR #77866 . :)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

This is what most distributions ship for `hfsprogs`,
significantly newer than 332.25 (10.4.11[1], 2005) but only
about half as old (first appears in 10.7[2], 2011).

The newer tools drop support for `mkfs.hfs` (creating an HFS partition)
however they retain the ability to check both HFS and HFS+.

This seems like a small cost, and can be addressed by either reviving
the 332.25 variant or using hfsutils[3][4].  Coming soon, maybe? :D

It seems HFS drives and images are already unsupported and have been
for quite some time, so while it is unfortunate to drop support
the filesystem creators Apple apparently are very done with it:

"With the introduction of Mac OS X 10.6, Apple dropped support for
formatting or writing HFS disks and images, which remain supported as
read-only volumes.  Starting with macOS 10.15, HFS disks can no longer
be read. "[5]

[1] https://opensource.apple.com/release/mac-os-x-10411x86.html
[2] https://opensource.apple.com/release/mac-os-x-107.html
[3] https://www.mars.org/home/rob/proj/hfs/
[4] https://packages.debian.org/source/sid/hfsutils (for patches)
[5] https://en.wikipedia.org/wiki/Hierarchical_File_System
@veprbl
Copy link
Member

veprbl commented Mar 30, 2020

@GrahamcOfBorg eval
@GrahamcOfBorg build hfsprogs

@veprbl
Copy link
Member

veprbl commented Mar 30, 2020

@GrahamcOfBorg eval

@stale

This comment has been minimized.

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Sep 26, 2020
@stale stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jan 18, 2021
@stale
Copy link

stale bot commented Jul 19, 2021

I marked this as stale due to inactivity. → More info

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jul 19, 2021
@wegank wegank marked this pull request as draft March 20, 2024 14:55
@stale stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Mar 20, 2024
@wegank wegank added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Mar 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.status: merge conflict 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants