Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pypi2nix: 2.0.2 -> 2.0.3 #77958

Merged
merged 1 commit into from Jan 18, 2020
Merged

pypi2nix: 2.0.2 -> 2.0.3 #77958

merged 1 commit into from Jan 18, 2020

Conversation

seppeljordan
Copy link
Contributor

@seppeljordan seppeljordan commented Jan 18, 2020 •
edited

Motivation for this change

The package pypi2nix changed upstream.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@marsam marsam merged commit 9e9095c into NixOS:master Jan 18, 2020
@marsam
Copy link
Contributor

marsam commented Jan 18, 2020

Thanks!

@seppeljordan
Copy link
Contributor Author

@marsam Thank you for maintaining nixpkgs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@seppeljordan @marsam