Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Building docks does not account the cost of clearing the sloped tile #7945

Closed
SamuXarick opened this issue Jan 17, 2020 · 1 comment
Closed

Building docks does not account the cost of clearing the sloped tile #7945

SamuXarick opened this issue Jan 17, 2020 · 1 comment
Labels
bug Something isn't working
Milestone
1.11.0

Comments

@SamuXarick
Copy link
Contributor

Version of OpenTTD

1.10.0-beta2

Expected result

Cost of dock + cost of clearing sloped tile

Actual result

Cost of dock

Steps to reproduce

Dock 1: Build a dock, see total cost
Dock 2: Clear sloped tile before building a dock, see total cost
SamuXarick added a commit to SamuXarick/OpenTTD that referenced this issue Jan 17, 2020
@SamuXarick
Fix OpenTTD#7945: Add cost of clearing the sloped tile when placing a…
99e8fe5 
… dock
SamuXarick added a commit to SamuXarick/OpenTTD that referenced this issue Jan 17, 2020
@SamuXarick
Fix OpenTTD#7945: Add cost of clearing the sloped tile when placing a…
fc2bacf 
… dock
SamuXarick added a commit to SamuXarick/OpenTTD that referenced this issue Jan 18, 2020
@SamuXarick
Fix OpenTTD#7945: Add cost of clearing the sloped tile when placing a…
a6f9dfe 
… dock

Fix: Regression results
SamuXarick added a commit to SamuXarick/OpenTTD that referenced this issue Feb 9, 2020
@SamuXarick
Fix OpenTTD#7945: Add cost of clearing the sloped tile when placing a…
a28df2e 
… dock

Fix: Regression results
SamuXarick added a commit to SamuXarick/OpenTTD that referenced this issue Feb 23, 2020
@SamuXarick
Fix OpenTTD#7945: Add cost of clearing the sloped tile when placing a…
dc0913c 
… dock

Fix: Regression results
SamuXarick added a commit to SamuXarick/OpenTTD that referenced this issue Feb 24, 2020
@SamuXarick
Fix OpenTTD#7945: Add cost of clearing the sloped tile when placing a…
ba1761f 
… dock

Fix: Regression results
SamuXarick added a commit to SamuXarick/OpenTTD that referenced this issue Feb 24, 2020
@SamuXarick
Fix OpenTTD#7945: Add cost of clearing the sloped tile when placing a…
bc6d1d1 
… dock

Fix: Regression results
SamuXarick added a commit to SamuXarick/OpenTTD that referenced this issue Feb 29, 2020
@SamuXarick
Fix OpenTTD#7945: Add cost of clearing the sloped tile when placing a…
b716745 
… dock

Fix: Regression results
SamuXarick added a commit to SamuXarick/OpenTTD that referenced this issue Mar 13, 2020
@SamuXarick
Fix OpenTTD#7945: Add cost of clearing the sloped tile when placing a…
b426734 
… dock

Fix: Regression results
SamuXarick added a commit to SamuXarick/OpenTTD that referenced this issue Apr 1, 2020
@SamuXarick
Fix OpenTTD#7945: Add cost of clearing the sloped tile when placing a…
94282de 
… dock

Fix: Regression results
SamuXarick added a commit to SamuXarick/OpenTTD that referenced this issue Apr 1, 2020
@SamuXarick
Fix OpenTTD#7945: Add cost of clearing the sloped tile when placing a…
a58bd76 
… dock

Fix: Regression results
@Yexo
Copy link
Contributor

Yexo commented May 10, 2020

Change seems fine. There is a related issue that the cost of clearing a coastal tile is inconsistent:

Clearing normal grass: 15
Clearing coastal tile: 30
Clearing grass with single tree: 15
Clearing coastal tile with single tree: 15

Looks like we intend to add a little cost for the coast, but fail to do so when there are trees.

SamuXarick added a commit to SamuXarick/OpenTTD that referenced this issue Jul 12, 2020
@SamuXarick
Fix OpenTTD#7945: Add cost of clearing the sloped tile when placing a…
5faaf4e 
… dock

Fix: Regression results
SamuXarick added a commit to SamuXarick/OpenTTD that referenced this issue Dec 17, 2020
@SamuXarick
Fix OpenTTD#7945: Add cost of clearing the sloped tile when placing a…
439c3ea 
… dock

Fix: Regression results
@SamuXarick SamuXarick mentioned this issue Dec 23, 2020
Merged
@TrueBrain TrueBrain added this to the 1.11.0 milestone Jan 5, 2021
@TrueBrain TrueBrain added the bug Something isn't working label Jan 7, 2021
TrueBrain pushed a commit to SamuXarick/OpenTTD that referenced this issue Jan 7, 2021
@SamuXarick @TrueBrain
Fix OpenTTD#7945: Add cost of clearing the sloped tile when placing a…
8ad11bd 
… dock
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
1.11.0
Development

No branches or pull requests
3 participants
@Yexo @TrueBrain @SamuXarick