Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sxiv: 25 -> 26, minor cleanup #77861

Merged
merged 1 commit into from Jan 19, 2020
Merged

sxiv: 25 -> 26, minor cleanup #77861

merged 1 commit into from Jan 19, 2020

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Jan 17, 2020

Motivation for this change

Upstream's changelog for this is reproduced below:

Maintenance release

馃榿

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from jfrankenau January 17, 2020 04:51
@dywedir
Copy link
Member

dywedir commented Jan 19, 2020

Thanks!

@dywedir dywedir merged commit 7db4b67 into NixOS:master Jan 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jfrankenau jfrankenau Awaiting requested review from jfrankenau

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dtzWill @dywedir