nix-shell: clean up the tmpDir and escape variables #3325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xzfc
commented
Jan 17, 2020
Comment on lines
+441
to
+430
| "trap _nix_shell_clean_tmpdir EXIT; " | ||
| "exitHooks+=(_nix_shell_clean_tmpdir); " | ||
| "failureHooks+=(_nix_shell_clean_tmpdir); ": |
There was a problem hiding this comment.
stdenv setup overrides the trap with exitHandler function which calls exitHook or failureHook. I've put the trap at line 441 as a fallback.
edolstra
reviewed
Feb 19, 2020
The problem fixed: each nix-shell invocation creates a new temporary
directory (`/tmp/nix-shell-*`) and never cleans up.
And while I'm here, shellescape all variables inlined into the rcfile.
See what might happen without escaping:
$ export TZ="';echo pwned'"
$ nix-shell -p hello --run hello
pwned
Hello, world!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem fixed: each nix-shell invocation creates a new temporary directory (
/tmp/nix-shell-*) and never cleans up.And while I'm here, shellescape all variables inlined into the rcfile. See what might happen without escaping: