Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[19.09] memcached: 1.5.16 -> 1.6.2 #83332

Closed
wants to merge 1 commit into from
Closed

[19.09] memcached: 1.5.16 -> 1.6.2 #83332

wants to merge 1 commit into from

Conversation

ajs124
Copy link
Member

@ajs124 ajs124 commented Mar 25, 2020

Motivation for this change

fixes remote DoS/possibly code execution, as described in
memcached/memcached#629

backport of 58a491a

cc @grahamc

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ajs124
memcached: 1.5.16 -> 1.6.2
5a0e5da 
fixes remote DoS/possibly code execution, as described in
memcached/memcached#629

backport of 58a491a
@Valodim
Copy link
Contributor

Valodim commented Mar 25, 2020

fwiw, according to the changelog, the security issue was introduced in memcached 1.6.0. so the 1.5.16 version shipped so far is not actually affected.

@ajs124
Copy link
Member Author

ajs124 commented Mar 25, 2020

Huh, I guess I only looked at the 1.6 changelog to check if is it backwards compatible.

@flokli
Copy link
Contributor

flokli commented Mar 29, 2020

So if this 1.5.x version isn't affected (and it's the latest 1.5.x), can this be closed?

@ajs124
Copy link
Member Author

ajs124 commented Mar 29, 2020

Probably

@ajs124 ajs124 closed this Mar 29, 2020
@ajs124 ajs124 deleted the backport/19.09/memcached branch March 29, 2020 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
1.severity: security 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ajs124 @Valodim @flokli @Mic92