Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rmtrash: init at 1.13 #83061

Merged
merged 1 commit into from Mar 25, 2020
Merged

rmtrash: init at 1.13 #83061

merged 1 commit into from Mar 25, 2020

Conversation

notpeelz
Copy link

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@notpeelz notpeelz force-pushed the rmtrash branch 3 times, most recently from 4516ed2 to e4f35c3 Compare March 21, 2020 21:06
@bqv
Copy link
Contributor

bqv commented Mar 22, 2020

LGTM with the suggested change

@notpeelz
Copy link
Author

notpeelz commented Mar 22, 2020 •
edited

  • repo name was changed to pname as @msteen suggested.
  • I combined postFixup script into installPhase
  • I added a couple missing dependencies: coreutils, which, getopt

jonringer
jonringer approved these changes Mar 25, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

diff LGTM
commit LGTM

[3 built, 1 copied (0.2 MiB), 0.0 MiB DL]
https://github.com/NixOS/nixpkgs/pull/83061
1 package built:
rmtrash

@jonringer jonringer merged commit c79b04a into NixOS:master Mar 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msteen msteen msteen left review comments

@jonringer jonringer jonringer approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@notpeelz @bqv @msteen @jonringer @louistakepillz