fitnesstrax: init at 0.1.0 #83336
fitnesstrax: init at 0.1.0 #83336
Conversation
ofborg
bot
added
8.has: package (new)
savannidgerinel
changed the title
|
Why doesn't your makefile do what is done in |
I haven't seen makefiles in Rust projects before, but I've also not seen much in the way of Rust-based executables. Perhaps this is just a place where the ecosystem doesn't have sufficient known standards? If you have an example, I would definitely follow it. Otherwise, I thought I had seen in my experiments that the shared/ folder just doesn't get copied into the destination. |
GLib provides https://gitlab.gnome.org/GNOME/glib/-/blob/master/m4macros/gsettings.m4, but you 'd need to use autotools. In that case I would really just recommend using meson. |
|
Oh, I thought you were using makefile somehow from looking at your project. Nevermind that then. |
|
I think you might want to delete this file from your repo https://github.com/luminescent-dreams/fitnesstrax/blob/sol/share/glib-2.0/schemas/gschemas.compiled. It's compiled but not meant to be distributed in that sense. |
I'll do that in the next release. I recall needing it to get the derivation right, but it may have been an intermediate step while I was flailing. |
|
Having addressed the changes, @worldofpeace and I get different sha256sums on the cargo file. I'm going to hold off until a few days and try stabilizing things on nixos-unstable, as suggested in IRC. |
ofborg
bot
added
the
11.by: package-maintainer
This is a fitness tracking application that I am developing.
The rebase was at the suggestion of worldofpeace in IRC. nixos-unstable may have updates to the Rust build infrastructure that don't exist in master. Nevertheless, this should still go into master. Still learning all of the processes. Harder than I expected.
Co-Authored-By: worldofpeace <worldofpeace@protonmail.ch>
I realized after looking at http://gtk-rs.org/docs/requirements.html that you only need gtk3 to build the gtk rust binding. gtk3 propagates all the other required development libs. This is why I only put gtk3 and glib.
|
I noticed something up with your deps, which I actually fixed for you a9f12d5. |
|
@worldofpeace I am not sure how to proceed. I had no idea that you could make a commit to a PR from a remote repository, so I don't know how to integrate this into my PR. And, I don't understand the error that grahamcofborg-eval is reporting. What do you advise as my next step? |
|
@savannidgerinel Just pull from origin. The error is a problem with ofborg that graham is fixing/maybe fixed. Will try an eval But generally, if you could build the package it should be fine. |
|
@savannidgerinel Squash merged, thanks ✨ |
Motivation for this change
This adds a fitness tracking application that I am developing.
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)