Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fitnesstrax: init at 0.1.0 #83336

Merged
merged 12 commits into from Apr 22, 2020
Merged

fitnesstrax: init at 0.1.0 #83336

merged 12 commits into from Apr 22, 2020

Conversation

savannidgerinel
Copy link
Contributor

@savannidgerinel savannidgerinel commented Mar 25, 2020

Motivation for this change

This adds a fitness tracking application that I am developing.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@savannidgerinel savannidgerinel changed the title Add a derivation for Fitnesstrax FitnessTrax: version 0.1.0 Mar 25, 2020
@Mic92 Mic92 changed the title FitnessTrax: version 0.1.0 FitnessTrax: init at 0.1.0 Mar 25, 2020
pkgs/applications/misc/fitnesstrax/default.nix Outdated Show resolved Hide resolved
pkgs/applications/misc/fitnesstrax/default.nix Outdated Show resolved Hide resolved
pkgs/applications/misc/fitnesstrax/default.nix Outdated Show resolved Hide resolved
pkgs/applications/misc/fitnesstrax/default.nix Outdated Show resolved Hide resolved
pkgs/applications/misc/fitnesstrax/default.nix Outdated Show resolved Hide resolved
pkgs/applications/misc/fitnesstrax/default.nix Outdated Show resolved Hide resolved
pkgs/applications/misc/fitnesstrax/default.nix Outdated Show resolved Hide resolved
@worldofpeace
Copy link
Contributor

worldofpeace commented Mar 26, 2020

Why doesn't your makefile do what is done in postInstall? I could see if I could find a project that does exactly this as an example.

@savannidgerinel
Copy link
Contributor Author

Why doesn't your makefile do what is done in postInstall? I could see if I could find a project that does exactly this as an example.

I haven't seen makefiles in Rust projects before, but I've also not seen much in the way of Rust-based executables. Perhaps this is just a place where the ecosystem doesn't have sufficient known standards?

If you have an example, I would definitely follow it. Otherwise, I thought I had seen in my experiments that the shared/ folder just doesn't get copied into the destination.

@worldofpeace
Copy link
Contributor

Why doesn't your makefile do what is done in postInstall? I could see if I could find a project that does exactly this as an example.

GLib provides https://gitlab.gnome.org/GNOME/glib/-/blob/master/m4macros/gsettings.m4, but you 'd need to use autotools. In that case I would really just recommend using meson.

@worldofpeace
Copy link
Contributor

Oh, I thought you were using makefile somehow from looking at your project. Nevermind that then.

@worldofpeace
Copy link
Contributor

I think you might want to delete this file from your repo https://github.com/luminescent-dreams/fitnesstrax/blob/sol/share/glib-2.0/schemas/gschemas.compiled. It's compiled but not meant to be distributed in that sense.

@savannidgerinel
Copy link
Contributor Author

I think you might want to delete this file from your repo https://github.com/luminescent-dreams/fitnesstrax/blob/sol/share/glib-2.0/schemas/gschemas.compiled. It's compiled but not meant to be distributed in that sense.

I'll do that in the next release. I recall needing it to get the derivation right, but it may have been an intermediate step while I was flailing.

@savannidgerinel
Copy link
Contributor Author

Having addressed the changes, @worldofpeace and I get different sha256sums on the cargo file. I'm going to hold off until a few days and try stabilizing things on nixos-unstable, as suggested in IRC.

This is a fitness tracking application that I am developing.
The rebase was at the suggestion of worldofpeace in IRC. nixos-unstable
may have updates to the Rust build infrastructure that don't exist in
master. Nevertheless, this should still go into master.

Still learning all of the processes. Harder than I expected.
Co-Authored-By: worldofpeace <worldofpeace@protonmail.ch>
I realized after looking at http://gtk-rs.org/docs/requirements.html
that you only need gtk3 to build the gtk rust binding.
gtk3 propagates all the other required development libs.
This is why I only put gtk3 and glib.
@worldofpeace
Copy link
Contributor

I noticed something up with your deps, which I actually fixed for you a9f12d5.
Only system libs you'd need would have been for gtk-rs.

@savannidgerinel
Copy link
Contributor Author

@worldofpeace I am not sure how to proceed. I had no idea that you could make a commit to a PR from a remote repository, so I don't know how to integrate this into my PR.

And, I don't understand the error that grahamcofborg-eval is reporting.

What do you advise as my next step?

@worldofpeace
Copy link
Contributor

worldofpeace commented Apr 3, 2020

@savannidgerinel Just pull from origin.

The error is a problem with ofborg that graham is fixing/maybe fixed.

Will try an eval
@GrahamcOfBorg eval

But generally, if you could build the package it should be fine.
(though the metadata could be messed up, but I don't think it is)

@worldofpeace worldofpeace changed the title FitnessTrax: init at 0.1.0 fitnesstrax: init at 0.1.0 Apr 3, 2020
@worldofpeace worldofpeace merged commit ccb580f into NixOS:master Apr 22, 2020
@worldofpeace
Copy link
Contributor

@savannidgerinel Squash merged, thanks ✨

@savannidgerinel savannidgerinel deleted the savanni-fitnesstrax branch April 22, 2020 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants