Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.beets: add unconditionally deps needed for checks #83322

Merged
merged 2 commits into from Mar 31, 2020
Merged

pythonPackages.beets: add unconditionally deps needed for checks #83322

merged 2 commits into from Mar 31, 2020

Conversation

doronbehar
Copy link
Contributor

@doronbehar doronbehar commented Mar 24, 2020 •
edited

Motivation for this change

Make an override such as:

    enableThumbnails            = false;

And some other enable* = false; not make the build fail the tests due to missing test requirements.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested review from aszlig, domenkozar and pjones March 24, 2020 22:42
@drewrisinger
Copy link
Contributor

The diff looks good to me, haven't tested build locally. Could you double-quote the homepage?

timokau
timokau approved these changes Mar 31, 2020
View reviewed changes
Copy link
Member

@timokau timokau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks! I'm slightly uncomfortable with testing a different setup than the one we're installing, but its preferable to not running any tests.

@timokau timokau merged commit e2c72fa into NixOS:master Mar 31, 2020
@doronbehar doronbehar deleted the improve-beets-test branch December 18, 2021 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timokau timokau timokau approved these changes

@aszlig aszlig Awaiting requested review from aszlig

@domenkozar domenkozar Awaiting requested review from domenkozar

@pjones pjones Awaiting requested review from pjones

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@doronbehar @drewrisinger @timokau