Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[css-text] Following up on #22309 #22458

Merged
merged 1 commit into from Apr 10, 2020
Merged

[css-text] Following up on #22309 #22458

merged 1 commit into from Apr 10, 2020

Conversation

frivoal
Copy link
Contributor

@frivoal frivoal commented Mar 26, 2020

As discussed in #22309 (comment)

@frivoal frivoal requested a review from litherum March 26, 2020 07:14
@frivoal frivoal self-assigned this Mar 26, 2020
wpt-pr-bot
wpt-pr-bot approved these changes Mar 26, 2020
View reviewed changes
Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Peer review is not required for CSS editors.

@frivoal frivoal mentioned this pull request Mar 26, 2020
Merged
@litherum
Copy link
Contributor

Sorry for being ignorant, but how does a test advertise that it is a “should”-level test?

@frivoal
Copy link
Contributor Author

frivoal commented Mar 27, 2020

how does a test advertise that it is a “should”-level test?

<meta name="flags" content="should">

Documented here: https://web-platform-tests.org/writing-tests/css-metadata.html#requirement-flags

I believe this is not (yet) taken into account by wpt.fyi, but it is by testharness.

@frivoal frivoal merged commit 8450219 into web-platform-tests:master Apr 10, 2020
@frivoal frivoal deleted the followup-22309 branch April 10, 2020 01:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wpt-pr-bot wpt-pr-bot wpt-pr-bot approved these changes

@litherum litherum Awaiting requested review from litherum

Assignees

@frivoal frivoal

Labels
css-text wg-css
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@frivoal @litherum @wpt-pr-bot