python3Packages.dipy: init at 1.1.1 #83359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Don't know why I'm mentioned, but can you run some tests at least? Other
than just import checks?
Drew Risinger
…On Wed, Mar 25, 2020 at 10:10 AM Ben Darwin ***@***.***> wrote:
Motivation for this change Things done
- Tested using sandboxing (nix.useSandbox
<http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox> on
NixOS, or option sandbox in nix.conf
<http://nixos.org/nix/manual/#sec-conf-file> on non-NixOS linux)
- Built on platform(s)
- NixOS
- macOS
- other Linux distributions
- [NA] Tested via one or more NixOS test(s) if existing and applicable
for the change (look inside nixos/tests
<https://github.com/NixOS/nixpkgs/blob/master/nixos/tests>)
- [NA] Tested compilation of all pkgs that depend on this change using nix-shell
-p nixpkgs-review --run "nixpkgs-review wip"
- Tested execution of all binary files (usually in ./result/bin/)
- Determined the impact on package closure size (by running nix
path-info -S before and after)
- Ensured that relevant documentation is up to date
- Fits CONTRIBUTING.md
<https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md>.
cc @lheckemann <https://github.com/lheckemann> @drewrisinger
<https://github.com/drewrisinger>
------------------------------
You can view, comment on, or merge this pull request online at:
#83359
Commit Summary
- python3Packages.dipy: init at 1.1.1
File Changes
- *A* pkgs/development/python-modules/dipy/default.nix
<https://github.com/NixOS/nixpkgs/pull/83359/files#diff-4336360be21e2369d6c3a1a7d375d3e3>
(83)
- *M* pkgs/top-level/python-packages.nix
<https://github.com/NixOS/nixpkgs/pull/83359/files#diff-2afbba83e1b14f9e0c304c769831a0e2>
(2)
Patch Links:
- https://github.com/NixOS/nixpkgs/pull/83359.patch
- https://github.com/NixOS/nixpkgs/pull/83359.diff
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#83359>, or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACNZYI26F46P6UWISOJMV7LRJIGD7ANCNFSM4LTPAMYQ>
.
|
|
The main issue is that the recommended way of running tests, |
|
Just if you had any comments about how |
Depends on if cvxpy is a hard requirement or optional. Seems fine if optional. |
|
Built on non-nix linux Result of 2 package built:
|
jonringer
reviewed
Mar 25, 2020
drewrisinger
suggested changes
Mar 25, 2020
jonringer
approved these changes
Mar 27, 2020
|
@GrahamcOfBorg build python37Packages.dipy python38Packages.dipy |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)cc @lheckemann @drewrisinger