Apply adjustments for 'text-anchor' after 'textLength' for <textPath> #22422
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Mar 24, 2020
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2116236
branch
from
35c2c0c
to
8025c23
Compare
When computing the position on the path for 'text-anchor' adjustments, any potential adjustments performed for 'textLength' needs to be considered. Previously the adjustment was computed as part of the summation of the chunk lengths. Bug: 603995 Change-Id: I579688e9ecf33a17898ecf228de6d44337455ed8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2116236 Reviewed-by: Stephen Chenney <schenney@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#753299}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2116236
branch
from
8025c23
to
083c2c5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When computing the position on the path for 'text-anchor' adjustments,
any potential adjustments performed for 'textLength' needs to be
considered. Previously the adjustment was computed as part of the
summation of the chunk lengths.
Bug: 603995
Change-Id: I579688e9ecf33a17898ecf228de6d44337455ed8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2116236
Reviewed-by: Stephen Chenney <schenney@chromium.org>
Commit-Queue: Fredrik Söderquist <fs@opera.com>
Cr-Commit-Position: refs/heads/master@{#753299}