Force SSE2 floats for i686 targets #566
Merged
+12
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nabijaczleweli
force-pushed
the
fix-i686-tests
branch
from
0784fb9 to
518692a
Compare
|
The use of x87 fp does not cause loss of precision. On the countrary! |
|
Right |
whitequark
suggested changes
Mar 24, 2020
There was a problem hiding this comment.
I suggest a few minor changes, looks good otherwise.
Regarding MSVC, I believe it does the reasonable thing by default so no further action is required.
| @@ -80,11 +80,17 @@ endif() | |||
| if(MINGW) | |||
| set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} -static-libgcc") | |||
| set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -static-libgcc -static-libstdc++") | |||
| endif() | |||
|
|
|||
There was a problem hiding this comment.
A comment here would help. Something like:
Suggested change
| # Ensure that all platforms use 64-bit IEEE floating point operations for consistency; this is | |
| # most important for the testsuite, which compares savefiles directly and depends on consistent | |
| # rounding of intermediate results. |
|
OK makes sense. The "compares savefiles directly" explains it. |
Both GCC and Clang use x87 instructions by default on 32-bit x86 targets, but the loss of precision resulting from that has yielded crashing tests (see referenced issue), and it can be safely assumed there are very few CPUs that both don't support SSE2 and are expected to run SolveSpace This commit also removes a now-redundant check for 32-bit Windows against TARGET, which doesn't seem to be actually set by CMake at all Ref: solvespace#565
nabijaczleweli
force-pushed
the
fix-i686-tests
branch
from
518692a to
211318a
Compare
|
Review addressed |
whitequark
approved these changes
Mar 24, 2020
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just GCC and Clang, I don't have a way to test MSVC behaviour.
Ref: #565