Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gtk3: fix clipboard related crashes in wayland #83303

Merged
merged 1 commit into from Mar 24, 2020
Merged

gtk3: fix clipboard related crashes in wayland #83303

merged 1 commit into from Mar 24, 2020

Conversation

hedning
Copy link
Contributor

@hedning hedning commented Mar 24, 2020

Motivation for this change

Some apps tended to crash when using the clipboard (eg. firefox-wayland
and evince).

https://gitlab.gnome.org/GNOME/gtk/-/merge_requests/1528

Things done

(on top of master)

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@hedning
gtk3: fix clipboard related crashes in wayland
e045b83 
Some apps tended to crash when using the clipboard (eg. firefox-wayland
and evince).

https://gitlab.gnome.org/GNOME/gtk/-/merge_requests/1528
@hedning hedning merged commit 83d1e9e into NixOS:staging Mar 24, 2020
@hedning hedning deleted the gtk-fix-wayland-crash branch March 24, 2020 20:51
dtzWill pushed a commit to dtzWill/nixpkgs that referenced this pull request Jun 3, 2020
@hedning @dtzWill
gtk3: fix clipboard related crashes in wayland (NixOS#83303)
7264860 
Some apps tended to crash when using the clipboard (eg. firefox-wayland
and evince).

https://gitlab.gnome.org/GNOME/gtk/-/merge_requests/1528
(cherry picked from commit 83d1e9e)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@7c6f434c 7c6f434c 7c6f434c approved these changes

@vcunat vcunat Awaiting requested review from vcunat

@worldofpeace worldofpeace Awaiting requested review from worldofpeace

Assignees
No one assigned
Labels
10.rebuild-darwin: 501-1000 10.rebuild-darwin: 501+ 10.rebuild-linux: 501+ 10.rebuild-linux: 2501-5000
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@hedning @7c6f434c