ocamlPackages.gnuplot: 0.5.3 → 0.7 #83402
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@GrahamcOfBorg build ocamlPackages.ocaml-r ocamlPackages.gnuplot ocamlPackages.phylogenetics |
bcdarwin
approved these changes
Mar 26, 2020
| description = "OCaml bindings for the R interpreter"; | ||
| inherit (src.meta) homepage; | ||
| license = lib.licenses.gpl3; | ||
| }; |
There was a problem hiding this comment.
Feel free to add me as maintainer if you want.
| }; | ||
|
|
||
| preConfigure = '' | ||
| substituteInPlace stubgen/stubgen.ml --replace 'failwithf "not supported: %s" name ()' 'sprintf "(* not supported: %s *)" name' |
There was a problem hiding this comment.
I’ve split the line and added a comment to justify it. Maybe worth reporting the issue upstream.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Drop dependency of ocaml-gnuplot on the
corelibrary.The
phylogeneticspackage must be updated for compatibility with ocaml-gnuplot (cc @bcdarwin).Updated phylogenetics depends on ocaml-r, which is thus packaged in this PR too.
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)