Skip to content

malcontent: 0.6.0 → 0.7.0 #83400

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 8, 2020
Merged

malcontent: 0.6.0 → 0.7.0 #83400

merged 4 commits into from
Apr 8, 2020
+134 −32

Conversation

jtojnar
Copy link
Member

@jtojnar jtojnar commented Mar 26, 2020

Motivation for this change

Changes: https://gitlab.freedesktop.org/pwithnall/malcontent/-/commit/2e8a07d58c047f757e36a5fcf1d5b76faae08e75

Allows us to split the UI package.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@ofborg ofborg bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Mar 26, 2020
@jtojnar jtojnar requested review from worldofpeace and hedning March 26, 2020 02:49
@jtojnar
Copy link
Member Author

jtojnar commented Mar 26, 2020

On staging gnome-initial-setup depends on malcontent-ui so we will need to disable it first. See #83403.

worldofpeace
worldofpeace approved these changes Mar 28, 2020
View reviewed changes
Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made two minor changes, and I read over https://gitlab.freedesktop.org/pwithnall/malcontent/-/merge_requests/38 and the patches. It sucks we can't get perfect separation.
Installed tests work for me also (though I got a weird unreproducible failure when I first built them).

@worldofpeace
Copy link
Contributor

Forgot to mention motivation for enabling accounts-service in the module. It does require it so we should just do it there anyways.

@jtojnar
Copy link
Member Author

jtojnar commented Apr 1, 2020

@GrahamcOfBorg eval

@ofborg ofborg bot added the ofborg-internal-error Ofborg encountered an error label Apr 2, 2020
@grahamc
Copy link
Member

grahamc commented Apr 2, 2020 •
edited
Loading

@GrahamcOfBorg eval

@grahamc
Copy link
Member

grahamc commented Apr 2, 2020

(note I'm actively debugging this)

@grahamc grahamc removed the ofborg-internal-error Ofborg encountered an error label Apr 2, 2020
jtojnar and others added 4 commits April 8, 2020 17:08
@jtojnar
malcontent: 0.6.0 → 0.7.0
4b4c016 
https://gitlab.freedesktop.org/pwithnall/malcontent/commit/2e8a07d58c047f757e36a5fcf1d5b76faae08e75
@jtojnar
malcontent-ui: split from malcontent

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
f3d1333 
The 0.7.0 update allows us to split the package.
@jtojnar
malcontent: Fix installed tests
4e68e0a 
Installed tests tried to load the PAM module from installed tests prefix instead of the configured pamlibdir.

Forgot to do this in 0.5.0 bump.
@worldofpeace @jtojnar
nixos/malcontent: enable accounts-daemon, tweak description
309fed2
@jtojnar jtojnar merged commit 521ddb1 into NixOS:master Apr 8, 2020
@jtojnar jtojnar deleted the malcontent-0.7 branch April 8, 2020 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worldofpeace worldofpeace

@hedning hedning

Assignees
No one assigned
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jtojnar @worldofpeace @grahamc