Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GNOME fixes #83403

Merged
merged 3 commits into from Mar 27, 2020
Merged

GNOME fixes #83403

merged 3 commits into from Mar 27, 2020

Conversation

jtojnar
Copy link
Contributor

@jtojnar jtojnar commented Mar 26, 2020 •
edited

Motivation for this change

Fixing few issues I noticed while using GNOME 3.36.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@jtojnar
gnome3.gnome-initial-setup: disable parental controls
3ead7c7 
This is not tested yet.
@jtojnar
gnome3.gnome-shell: Fix Telepathy integration
f61053d
@jtojnar
gnome3.gnome-shell: Fix screen recorder
93095d1 
Trying to record screen (ctr-alt-shift-r) fails with the following logged:

	Can't create videoconvert element
	shell_recorder_close: assertion 'recorder->state != RECORDER_STATE_CLOSED' failed

videoconvert plug-in is part of gst-plugins-base.
@ofborg ofborg bot requested review from worldofpeace and hedning March 26, 2020 04:20
@jtojnar jtojnar marked this pull request as ready for review March 26, 2020 05:11
@jtojnar jtojnar mentioned this pull request Mar 26, 2020
Merged
10 tasks
hedning
hedning approved these changes Mar 27, 2020
View reviewed changes
Copy link
Contributor

@hedning hedning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me :) Just noticed that the screen recorder didn't work so good getting that fixed before 3.36 hits unstable.

@jtojnar
Copy link
Contributor Author

jtojnar commented Mar 27, 2020

It is weird, though, since I would expect the base plugins to be propagated by good. Maybe another fallout from the wrapper changes?

@hedning
Copy link
Contributor

hedning commented Mar 27, 2020

Hmm, looks like «good» doesn't propagate «base», which I guess it probably should. So it looks like we simply lost «base» when removing clutter.

@jtojnar jtojnar merged commit 10c984c into NixOS:staging Mar 27, 2020
@jtojnar jtojnar deleted the gnome-fixes branch March 27, 2020 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hedning hedning hedning approved these changes

@worldofpeace worldofpeace Awaiting requested review from worldofpeace

Assignees
No one assigned
Labels
6.topic: GNOME GNOME desktop environment and its underlying platform 10.rebuild-darwin: 0 10.rebuild-linux: 11-100 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jtojnar @hedning