Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generalize Derivation type to better support unresolved derivations #3446

Draft
wants to merge 40 commits into
base: master
Choose a base branch
from

Conversation

Ericson2314
Copy link
Member

@Ericson2314 Ericson2314 commented Mar 25, 2020

This is basically an extended meditation on the Derivation types and hashDerivationModulo. I wanted to break things into smaller steps (resolving drvs vs hashing them vs making output paths), in preparation for things like the intensional store and better remote building.

Each commit can be reviewed separately; they all should build, and, except for the second to last, each should leave the code in a working state.

Not sure whether this or #3439 is more likely to get merged first, but the combination should work well together. Indeed it does, and that is now this PR.

Depends on #3434
Depends on #3883

This will allow us to express intermediate values of
`hashDerivationModulo` in the following commit.
@Ericson2314 Ericson2314 changed the title Big Derivation refactor Big Derivation refactor -- contains #3449 Mar 30, 2020
@Ericson2314 Ericson2314 changed the title Big Derivation refactor -- contains #3449 Big Derivation refactor -- contains #3439, #3449 Mar 30, 2020
@Ericson2314 Ericson2314 changed the title Big Derivation refactor -- contains #3439, #3449 WIP: Big Derivation refactor -- contains #3439, #3449 Apr 9, 2020
@Ericson2314 Ericson2314 changed the title WIP: Big Derivation refactor -- contains #3439, #3449 WIP: Big Derivation refactor -- contains #3449 Jun 21, 2020
@Ericson2314 Ericson2314 changed the title Generalize Derivation type to better support unresolved derivations -- contains #3434 & #3883 WIP: Generalize Derivation type to better support unresolved derivations -- contains #3434 & #3883 Aug 20, 2020
@stale
Copy link

stale bot commented Feb 18, 2021

I marked this as stale due to inactivity. → More info

@stale stale bot added the stale label Feb 18, 2021
@stale
Copy link

stale bot commented Apr 16, 2022

I closed this issue due to inactivity. → More info

@stale stale bot closed this Apr 16, 2022
@Ericson2314 Ericson2314 reopened this Nov 21, 2022
@Ericson2314 Ericson2314 changed the title WIP: Generalize Derivation type to better support unresolved derivations -- contains #3434 & #3883 WIP: Generalize Derivation type to better support unresolved derivations Feb 14, 2023
@stale stale bot removed the stale label Feb 14, 2023
@Ericson2314 Ericson2314 marked this pull request as draft February 14, 2023 20:48
@Ericson2314 Ericson2314 changed the title WIP: Generalize Derivation type to better support unresolved derivations WIP: Generalize Derivation type to better support unresolved derivations Apr 19, 2023
@Ericson2314 Ericson2314 changed the title WIP: Generalize Derivation type to better support unresolved derivations Generalize Derivation type to better support unresolved derivations Apr 19, 2023
@github-actions github-actions bot added new-cli Relating to the "nix" command repl The Read Eval Print Loop, "nix repl" command and debugger store Issues and pull requests concerning the Nix store with-tests Issues related to testing. PRs with tests have some priority labels Apr 19, 2023
@Ericson2314 Ericson2314 changed the base branch from master to 0.5-release May 18, 2023 20:35
@Ericson2314 Ericson2314 changed the base branch from 0.5-release to master May 18, 2023 20:35
@github-actions github-actions bot added the fetching Networking with the outside (non-Nix) world label May 18, 2023
@tomberek
Copy link
Contributor

Still needed after the large amount of existing re-work of derivation representation?

@Ericson2314
Copy link
Member Author

Ericson2314 commented Oct 30, 2023

I would still like to do something along these lines. It is a different sort of change than the things done so far. The history might be an unsalvagable mess, but I soon as well reuse this PR even if I just remake it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fetching Networking with the outside (non-Nix) world new-cli Relating to the "nix" command repl The Read Eval Print Loop, "nix repl" command and debugger store Issues and pull requests concerning the Nix store with-tests Issues related to testing. PRs with tests have some priority
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants