New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generalize Derivation
type to better support unresolved derivations
#3446
Draft
Ericson2314
wants to merge
40
commits into
NixOS:master
Choose a base branch
from
Ericson2314:derivation-template
base: master
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will allow us to express intermediate values of `hashDerivationModulo` in the following commit.
Ericson2314
changed the title
Big Derivation refactor
Big Derivation refactor -- contains #3449
Mar 30, 2020
Use the newly parameterized derivation types to enforce the invariants needed to split these.
Ericson2314
force-pushed
the
derivation-template
branch
from
March 30, 2020 19:55
26d0c60
to
c467f42
Compare
Ericson2314
changed the title
Big Derivation refactor -- contains #3449
Big Derivation refactor -- contains #3439, #3449
Mar 30, 2020
Ericson2314
changed the title
Big Derivation refactor -- contains #3439, #3449
WIP: Big Derivation refactor -- contains #3439, #3449
Apr 9, 2020
…son2314/nix into derivation-template
…/nix into derivation-template-temp
Ericson2314
changed the title
WIP: Big Derivation refactor -- contains #3439, #3449
WIP: Big Derivation refactor -- contains #3449
Jun 21, 2020
… into derivation-template
…into just-derivation-template
… into derivation-template
…tems/nix into derivation-template
This is much better than making the caller responsible.
…ystems/nix into derivation-template
Ericson2314
changed the title
Generalize Derivation type to better support unresolved derivations -- contains #3434 & #3883
WIP: Generalize Derivation type to better support unresolved derivations -- contains #3434 & #3883
Aug 20, 2020
I marked this as stale due to inactivity. → More info |
I closed this issue due to inactivity. → More info |
Ericson2314
changed the title
WIP: Generalize Derivation type to better support unresolved derivations -- contains #3434 & #3883
WIP: Generalize Derivation type to better support unresolved derivations
Feb 14, 2023
Ericson2314
changed the title
WIP: Generalize Derivation type to better support unresolved derivations
WIP: Generalize Apr 19, 2023
Derivation
type to better support unresolved derivations
Ericson2314
changed the title
WIP: Generalize
Generalize Apr 19, 2023
Derivation
type to better support unresolved derivationsDerivation
type to better support unresolved derivations
github-actions
bot
added
new-cli
Relating to the "nix" command
repl
The Read Eval Print Loop, "nix repl" command and debugger
store
Issues and pull requests concerning the Nix store
with-tests
Issues related to testing. PRs with tests have some priority
labels
Apr 19, 2023
github-actions
bot
added
the
fetching
Networking with the outside (non-Nix) world
label
May 18, 2023
Still needed after the large amount of existing re-work of derivation representation? |
I would still like to do something along these lines. It is a different sort of change than the things done so far. The history might be an unsalvagable mess, but I soon as well reuse this PR even if I just remake it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
fetching
Networking with the outside (non-Nix) world
new-cli
Relating to the "nix" command
repl
The Read Eval Print Loop, "nix repl" command and debugger
store
Issues and pull requests concerning the Nix store
with-tests
Issues related to testing. PRs with tests have some priority
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is basically an extended meditation on the
Derivation
types andhashDerivationModulo
. I wanted to break things into smaller steps (resolving drvs vs hashing them vs making output paths), in preparation for things like the intensional store and better remote building.Each commit can be reviewed separately; they all should build, and, except for the second to last, each should leave the code in a working state.
Not sure whether this or #3439 is more likely to get merged first, but the combination should work well together.Indeed it does, and that is now this PR.Depends on #3434
Depends on #3883