weechatScripts.wee-slack: 2.4.0 -> 2.5.0 #83339
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 tasks
Mic92
reviewed
Mar 25, 2020
| @@ -21,11 +21,18 @@ stdenv.mkDerivation rec { | |||
| }) | |||
| ]; | |||
|
|
|||
| postPatch = '' | |||
| substituteInPlace wee_slack.py --replace \ | |||
There was a problem hiding this comment.
Could you make this a patch instead? This way we will not silently break it, when upgrading wee slack in future. Thanks!
There was a problem hiding this comment.
Good idea! I’ve updated the PR. I believe it’s still necessary to use substituteInPlace, based on what I see being done in other derivations, but at least now the entire build will fail if the patch doesn’t apply cleanly.
wee-slack now (optionally) depends on a data file called weemoji.json that allows it to translate between Slack emoji names (like "slight_smile") and Unicode codepoints. For convenience, the derivation now installs this file and patches the script so that the user doesn't need to do any extra configuration to use it.
bdesham
force-pushed
the
wee-slack-2.5.0
branch
from
74dd763
to
a2d9581
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Version bump. The changes are listed on the GitHub release page.
wee-slack now (optionally) depends on a data file called weemoji.json
that allows it to translate between Slack emoji names (like
"slight_smile") and Unicode codepoints. For convenience, the derivation
now installs this file and patches the script so that the user doesn't
need to do any extra configuration to use it.
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)cc @WilliButz