Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pixiecore: init at 2020-03-25 #83373

Merged
merged 1 commit into from Mar 26, 2020
Merged

pixiecore: init at 2020-03-25 #83373

merged 1 commit into from Mar 26, 2020

Conversation

bbigras
Copy link
Contributor

@bbigras bbigras commented Mar 25, 2020

Motivation for this change

This is a rebase of #62113 (without the module, I'll do that next). I added the other contributor as a Co-authored-by.

package and module requested in #49740

Note that according to https://github.com/danderson/netboot the project is "no longer actively developed". But it still works fine and it's a really useful tool. See https://nixos.wiki/wiki/Netboot

@Lassulus @aanderse @Ekleog

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from kalbasit March 25, 2020 20:03
@bbigras
Copy link
Contributor Author

bbigras commented Mar 25, 2020

You are right @Valodim . Thanks! I made the change.

@Valodim
Copy link
Contributor

Valodim commented Mar 25, 2020

you'll still have to point the repo attribute to netboot :)

@bbigras
Copy link
Contributor Author

bbigras commented Mar 26, 2020

Right, sorry.

@bbigras bbigras mentioned this pull request Mar 26, 2020
Merged
10 tasks
@bbigras @OYEdeploy
pixiecore: init at 2020-03-25
78fbe7d 
Co-authored-by: raunovv <rauno@oyenetwork.com>
@ofborg ofborg bot requested a review from danderson March 26, 2020 05:02
@Mic92 Mic92 merged commit 461784f into NixOS:master Mar 26, 2020
@bbigras bbigras deleted the pixiecore branch March 26, 2020 13:21
@bbigras
Copy link
Contributor Author

bbigras commented Mar 26, 2020

Thanks!

@Mic92 Mic92 mentioned this pull request Apr 2, 2020
Closed
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Valodim Valodim Valodim left review comments

@kalbasit kalbasit Awaiting requested review from kalbasit

@danderson danderson Awaiting requested review from danderson

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bbigras @Valodim @Mic92