script_defs: open state files and deployments with a context manager #1263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grahamc
force-pushed
the
context-manager
branch
4 times, most recently
from
2841369
to
0c7c2a6
Compare
adisbladis
reviewed
Mar 24, 2020
grahamc
force-pushed
the
context-manager
branch
from
0c7c2a6
to
f37541a
Compare
grahamc
force-pushed
the
context-manager
branch
from
f37541a
to
4d014a9
Compare
grahamc
commented
Mar 26, 2020
| state = nixops.statefile.StateFile(args.state_file) | ||
| try: | ||
| yield state | ||
| finally: |
There was a problem hiding this comment.
This used to catch the exception and no longer tries to.
domenkozar
reviewed
Mar 26, 2020
| "ssh://{}".format(m.get_ssh_name()), | ||
| args.storepath, | ||
| ], | ||
| m.logger, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use context managers to open and manage statefiles and deployments. This lets us do some fancier things with those state files. For example, storing the state other places.
This change is almost entirely whitespace. Check it out without whitespace in the diff: https://github.com/NixOS/nixops/pull/1263/files?w=1
Also consider looking commit-by-commit, which makes it easier, I think, to review.
Here is a diff adding state backends using this: legacy, in-memory, and s3: https://github.com/grahamc/nixops/compare/context-manager...grahamc:context-manager-states-rebase?expand=1