Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python.pkgs.bacpypes: init at 0.18.0 #76191

Merged
merged 1 commit into from Mar 24, 2020
Merged

python.pkgs.bacpypes: init at 0.18.0 #76191

merged 1 commit into from Mar 24, 2020

Conversation

bachp
Copy link
Member

@bachp bachp commented Dec 22, 2019

Motivation for this change

Include the bacnet python library in nixpkgs.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@bachp bachp changed the title python.pkgs.bacpypes: init at 0.17.7 python.pkgs.bacpypes: init at 0.18.0 Feb 26, 2020
@bachp
Copy link
Member Author

bachp commented Feb 26, 2020

@Ma27 @jonringer I fixed the test issue and also updated to 0.18.0 which was released in the meantime.

jonringer
jonringer reviewed Mar 2, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise LGTM

[5 built, 1 copied, 0.0 MiB DL]
https://github.com/NixOS/nixpkgs/pull/76191
3 package built:
python27Packages.bacpypes python37Packages.bacpypes python38Packages.bacpypes

pkgs/development/python-modules/bacpypes/default.nix Outdated Show resolved Hide resolved
@jonringer
Copy link
Contributor

please squash commits

@bachp @jonringer
python.pkgs.bacpypes: init at 0.18.0
baeff61 
Co-Authored-By: Jon <jonringer@users.noreply.github.com>
@bachp
Copy link
Member Author

bachp commented Mar 13, 2020

@jonringer Squashed

jonringer
jonringer approved these changes Mar 24, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

diff LGTM
commit LGTM
has tests 👍

[5 built, 3 copied (0.0 MiB), 0.0 MiB DL]
https://github.com/NixOS/nixpkgs/pull/76191
3 package built:
python27Packages.bacpypes python37Packages.bacpypes python38Packages.bacpypes

@jonringer
Copy link
Contributor

@GrahamcOfBorg build python27Packages.bacpypes python37Packages.bacpypes python38Packages.bacpypes

@jonringer jonringer merged commit b70d749 into NixOS:master Mar 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ma27 Ma27 Ma27 left review comments

@jonringer jonringer jonringer approved these changes

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bachp @jonringer @Ma27