Optionally export background colour in vector files #568
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think a new |
|
That's the approach I tried first but generalising which was quickly defeated by the PDF spec, heh. Moved the code to New SVG diffdiff --git a/no.svg b/yes.svg
index 934e483..b2cb55b 100644
--- a/no.svg
+++ b/yes.svg
@@ -115,6 +115,11 @@ stroke-linejoin:round;
fill:none;
}
]]></style>
+<style><![CDATA[
+svg {
+background-color:#006600;
+}
+]]></style>
<path d='M57.400 51.200 L57.400,5.000 L5.000,5.000 L5.000,51.200 L57.400,51.200 ' class='s0' />
<path d='M54.795 27.120 L55.465,28.965 L56.136,27.120 M30.649 50.093 L30.649,48.248 M31.655 50.093 L31.655,48.248 M30.649 49.068 L31.655,49.068 M6.335 27.120 L6.922,28.965 L7.509,27.120 M30.649 7.837 L30.649,5.825 M31.655 7.837 L31.655,5.825 M30.649 6.719 L31.655,6.719 ' class='s6' /> |
nabijaczleweli
force-pushed
the
export-background-colour-vector
branch
from
a1f2dc5
to
9e073b0
Compare
nabijaczleweli
force-pushed
the
export-background-colour-vector
branch
from
9e073b0
to
d4b0a64
Compare
VectorFileWriter::Background() is an empty impl, except that it writes * a rectangle the size of the output for EPS and PDF, and * a <style> element setting background-color for SVG Ref: solvespace#525
nabijaczleweli
force-pushed
the
export-background-colour-vector
branch
from
d4b0a64
to
5fc14c1
Compare
|
@whitequark what's the status of this one? |
whitequark
approved these changes
Sep 4, 2020
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Produces non-zero diffs for EPS, PDF, and SVG:
EPS
PDF
SVG
Converted to PNG with imagemagick:
EPS, no:
EPS, yes:
PDF, no:
PDF, yes:
SVG, no:
SVG, yes:
Config GUI option name might need some bikeshedding: "export background color" isn't exactly right since it's for vector files only "export background color in vector files" maybe?
Exports tested in the GUI only due to #567, but the option gets loaded right before crashing, so it should work.
This doesn't change exporting PNGs since those are screenshots and I don't know how to make them not so/if that's viable at all.
Ref: #525