Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

elmPackages.elm-instrument: remove patch #83352

Merged
merged 1 commit into from Mar 25, 2020

Conversation

turboMaCk
Copy link
Member

@turboMaCk turboMaCk commented Mar 25, 2020

PR is merged to master so patch is no longer needed (provided we use commit from master)

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@turboMaCk
Copy link
Member Author

@GrahamcOfBorg build elmPackages.elm-coverage

@turboMaCk
Copy link
Member Author

cc @domenkozar

@domenkozar domenkozar merged commit 2f39816 into NixOS:master Mar 25, 2020
@turboMaCk turboMaCk deleted the elm-instrument-remove-patch branch February 2, 2021 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants