Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

prometheus: 2.16.0 -> 2.17.1 #83371

Merged
merged 1 commit into from Apr 2, 2020
Merged

prometheus: 2.16.0 -> 2.17.1 #83371

merged 1 commit into from Apr 2, 2020

Conversation

Frostman
Copy link
Member

@Frostman Frostman commented Mar 25, 2020 •
edited

Motivation for this change

https://github.com/prometheus/prometheus/releases/tag/v2.17.1

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

This change is Reviewable

@Frostman
Copy link
Member Author

@GrahamcOfBorg test prometheus

@ofborg ofborg bot requested review from globin, benley, WilliButz and fpletz March 25, 2020 19:46
@Frostman
Copy link
Member Author

Seems like minio-related test fails sometimes - it passed successfully 4/5 times on my machine,

@Frostman
Copy link
Member Author

@GrahamcOfBorg test prometheus

@marsam
Copy link
Contributor

marsam commented Mar 27, 2020

2.17.1 was released https://github.com/prometheus/prometheus/releases/tag/v2.17.1, would you mind updating it?

@Frostman
Copy link
Member Author

Frostman commented Apr 1, 2020

@GrahamcOfBorg test prometheus

@Frostman Frostman changed the title prometheus: 2.16.0 -> 2.17.0 prometheus: 2.16.0 -> 2.17.1 Apr 1, 2020
@marsam marsam merged commit 820cc39 into NixOS:master Apr 2, 2020
@marsam
Copy link
Contributor

marsam commented Apr 2, 2020

@Frostman thank you!

@Frostman Frostman deleted the prom-2.17.0 branch April 2, 2020 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@globin globin Awaiting requested review from globin

@benley benley Awaiting requested review from benley

@WilliButz WilliButz Awaiting requested review from WilliButz

@fpletz fpletz Awaiting requested review from fpletz

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Frostman @marsam