Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.quandl: 3.4.8 -> 3.5.0 #83372

Merged
merged 1 commit into from Mar 27, 2020
Merged

pythonPackages.quandl: 3.4.8 -> 3.5.0 #83372

merged 1 commit into from Mar 27, 2020

Conversation

drewrisinger
Copy link
Contributor

Motivation for this change

Bump quandl version.

Format meta to match standard.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip". Found none.
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@drewrisinger
Copy link
Contributor Author

@GrahamcOfBorg build python27Packages.quandl python37Packages.quandl python38Packages.quandl

bhipple
bhipple requested changes Mar 26, 2020
View reviewed changes
Copy link
Contributor

@bhipple bhipple left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Diff LGTM, but the CI build has failed.

@drewrisinger
pythonPackages.quandl: 3.4.8 -> 3.5.0
80f2726 
Format meta to match standard practice.
@drewrisinger
Copy link
Contributor Author

@GrahamcOfBorg build python37Packages.quandl python38Packages.quandl

@drewrisinger
Copy link
Contributor Author

Output of nixpkgs-review pr 83372:

[2 built, 14 copied (8.8 MiB), 1.8 MiB DL]
https://github.com/NixOS/nixpkgs/pull/83372
2 package built:
python37Packages.Quandl python38Packages.Quandl

@drewrisinger drewrisinger mentioned this pull request Mar 26, 2020
Merged
10 tasks
jonringer
jonringer approved these changes Mar 27, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

diff LGTM

https://github.com/NixOS/nixpkgs/pull/83372
2 package built:
python37Packages.Quandl python38Packages.Quandl

@jonringer jonringer merged commit a845ade into NixOS:master Mar 27, 2020
@drewrisinger drewrisinger deleted the dr-pr-python-quandl-bump branch March 27, 2020 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@FRidh FRidh Awaiting requested review from FRidh

@bhipple bhipple Awaiting requested review from bhipple

Assignees
No one assigned
Labels
6.topic: python 8.has: clean-up 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@drewrisinger @bhipple @jonringer