[FlexNG] Implement transferred size suggestion #22431
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Mar 25, 2020
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2119174
branch
6 times, most recently
from
2b29f5b
to
5ef8dff
Compare
Aspect-ratio items with min-main:auto and a definite cross size use cross size * ratio as an input to the min-main:auto algorithm. FlexNG previously ignored that part of the spec. Bug: 845235,1064283 Change-Id: I22198e1255c70797aed83c045f76b8e23c029b3e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2119174 Commit-Queue: David Grogan <dgrogan@chromium.org> Reviewed-by: Christian Biesinger <cbiesinger@chromium.org> Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#754286}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2119174
branch
from
5ef8dff
to
6333099
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Aspect-ratio items with min-main:auto and a definite cross size use
cross size * ratio as an input to the min-main:auto algorithm. FlexNG
previously ignored that part of the spec.
Bug: 845235,1064283
Change-Id: I22198e1255c70797aed83c045f76b8e23c029b3e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2119174
Commit-Queue: David Grogan <dgrogan@chromium.org>
Reviewed-by: Christian Biesinger <cbiesinger@chromium.org>
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#754286}